Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @storybook/react peer dependency in @loki/integration-react #491

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

qooban
Copy link
Contributor

@qooban qooban commented Nov 29, 2023

This should solve issue with the following warnings observed when installing loki:

npm install --save-dev loki

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @loki/integration-react@0.33.0
npm WARN Found: @storybook/react@7.5.2
npm WARN node_modules/@storybook/react
npm WARN   dev @storybook/react@"^7.5.2" from the root project
npm WARN   3 more (@storybook/preset-react-webpack, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peerOptional @storybook/react@"^5 || ^6" from @loki/integration-react@0.33.0
npm WARN node_modules/loki/node_modules/@loki/integration-react
npm WARN   @loki/integration-react@"^0.33.0" from loki@0.33.0
npm WARN   node_modules/loki
npm WARN 
npm WARN Conflicting peer dependency: @storybook/react@6.5.16
npm WARN node_modules/@storybook/react
npm WARN   peerOptional @storybook/react@"^5 || ^6" from @loki/integration-react@0.33.0
npm WARN   node_modules/loki/node_modules/@loki/integration-react
npm WARN     @loki/integration-react@"^0.33.0" from loki@0.33.0
npm WARN     node_modules/loki

I'm using npm v10.1.0.

@qooban
Copy link
Contributor Author

qooban commented Dec 5, 2023

@oblador I have no rights not assign revierwers, would you mind looking at this small PR?

@oblador oblador merged commit f2d8a5c into oblador:master Jan 25, 2024
4 checks passed
@qooban qooban deleted the sb7-dep-fix branch January 26, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants