Changing from aws-chromelambda to @sparticuz/chromium #492
Conversation
| "start": "docker run -d -p 8080:8080 -t example-renderer-aws-lambda:latest" | ||
| }, | ||
| "dependencies": { | ||
| "@loki/renderer-aws-lambda": "file:../../packages/renderer-aws-lambda", |
There was a problem hiding this comment.
Instead of doing this, add this project to the workspace by adding it to workspaces.packages in the root package.json
There was a problem hiding this comment.
I did this way to be able to iterate during the development and have the dependencies updated inside node_modules when I installed them. If I use the version when I install this it will fetch from the npm and not from the code I changed.
Is there another way to achieve this?
I added in the other comment why I didn't use the workspace.
There was a problem hiding this comment.
There's an option for yarn workspaces called nohoist which I think should solve this problem: https://classic.yarnpkg.com/blog/2018/02/15/nohoist/
There was a problem hiding this comment.
Thanks for the suggestion. I did the change using workspace and nohoist.
package.json
Outdated
| @@ -10,7 +10,8 @@ | |||
| "scripts": { | |||
| "format": "prettier '{,packages/**/,examples/**/,website/**/,docs/**/,test/**/,.github/**/}*.{md,js,jsx,json,yml}' --write", | |||
| "lint": "eslint packages/*/src", | |||
| "test": "jest", | |||
| "prepare:lambda:test": "cd examples/running-renderer-aws-lambda && yarn build && yarn start", | |||
There was a problem hiding this comment.
Instead of cd ... use yarn workspace @loki/example-running-renderer-aws-lambda run build once you've fixed the workspace thing. Also maybe name this pretest so you can get rid of it in the line below.
There was a problem hiding this comment.
Ok, I'm going to change it to prestest. However, the problem with using the workspace is that I need the node_modules separated for this specific case. Do you have an idea how to do this? When a ran yarn install with workspace all node_modules goes to the root.
I need it separated to copy it into the docker.
|
Hey @oblador, do you have any news on this? Can I help with any other change or clarifying anything in the PR? Thanks :) |
|
Hey @oblador did the requested changes, please let me know if you have any other suggestion. |
|
Awesome, thanks! |
|
Released in 0.34.0 |
Following the discussion on this issue.
Change the library to use @sparticuz/chromium
Needed to make some small implementations.
Since dockerLambda is deprecated I changed the way that we test the lambda.
Please feel free to guide me if it doesn't suit the requirements.