Simple type validation in QueryFragment derive. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing QueryFragments, it's really easy to get confused about what GraphQL types are required, what are lists etc. When you get this wrong, the Rust compile errors are either not as helpful as they could be _or_ plain confusing. This updates the QueryFragment derive code to be a bit smarter here: it will specifically check for the cases where there's a mismatch in list types or optionalness. I've also updated it to error when people provide generic types in their structs. Currently this will cause a syntax error in the derive output, with an unhelpful message, so I'm just explicitly disallowing it for now. Can revisit fixing the underlying error at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing QueryFragments, it's really easy to get confused about
what GraphQL types are required, what are lists etc. When you get this
wrong, the Rust compile errors are either not as helpful as they could
be or plain confusing.
This updates the QueryFragment derive code to be a bit smarter here: it
will specifically check for the cases where there's a mismatch in list
types or optionalness.
I've also updated it to error when people provide generic types in their
structs. Currently this will cause a syntax error in the derive output,
with an unhelpful message, so I'm just explicitly disallowing it for
now. Can revisit fixing the underlying error at some point.