Rework argument & query serialization #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change we serialized arguments when building up the selection set, and stored the results of that serialization in the Argument struct. This worked, but led to an awkward API where you build the selection set, convert it to a QueryBody which could fail, and _then_ convert it to JSON which could also fail. This updates the Argument struct to store a `Box<SerializableArgument>` instead. This simplifies things: we can now serialize the Query directly, and the Argument serialization will happen there, leading to a single point of failure rather than multiple.
Rather than `()` which was a bit useless. Fixes #42
Was prefixing vars with $ in variables when they should have just had the names.
Fixes #45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change we serialized arguments when building up the
selection set, and stored the results of that serialization in the
Argument struct. This worked, but led to an awkward API where you build
the selection set, convert it to a QueryBody which could fail, and
then convert it to JSON which could also fail.
This updates the Argument struct to store a
Box<SerializableArgument>instead. This simplifies things: we can now serialize the Query
directly, and the Argument serialization will happen there, leading to a
single point of failure rather than multiple.
Also updated the serialize & encode functions to return
Box<Error>rather than
().Fixes #42
Fixes #45