-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2049 add has soma location 'retinal bipolar neuron' #2050
Conversation
Fixes #2049 add soma location OFF-bipolar cell
#gogoeditdiff |
Here's a diff of how these changes impact the classified ontology (on -simple file):Ontologies are identical |
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsOntology annotationsON-bipolar cell
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider if it is more appropriate to place this axiom at the level of the parent class, CL:0000748 'retinal bipolar neuron'.
Thank you for the suggestion, I will add this axiom to 'retinal bipolar neuron' and remove from ON-bipolar cell. As 'retinal neuron layer' had the EA 'bipolar neuron' and ('has soma location' some retina), all bipolar cells with soma in the retina would be classified under this class and therefore inherit 'has soma location' some 'inner nuclear layer of retina'. Therefore, it makes sense to substitute the EA to 'bipolar neuron' and ('has soma location' some 'inner nuclear layer of retina'). |
#gogoeditdiff |
I think moving the soma location axiom to the more general term makes sense from what I know of the biology. For a broader review of the biology - I've found this useful: Euler, T., Haverkamp, S., Schubert, T., & Baden, T. (2014). Retinal bipolar cells: elementary building blocks of vision. Nature Reviews Neuroscience, 15(8), 507–519. https://doi.org/10.1038/nrn3783 |
Fixes #2049 add soma location OFF-bipolar cell