Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2049 add has soma location 'retinal bipolar neuron' #2050

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

aleixpuigb
Copy link
Collaborator

Fixes #2049 add soma location OFF-bipolar cell

Fixes #2049 add soma location OFF-bipolar cell
@aleixpuigb aleixpuigb added CL-classhierarchy HuBMAP Needed/useful for HuBMAP labels Jun 30, 2023
@aleixpuigb aleixpuigb self-assigned this Jun 30, 2023
@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

@github-actions
Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontologies are identical

@github-actions
Copy link

github-actions bot commented Jun 30, 2023

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

ON-bipolar cell http://purl.obolibrary.org/obo/CL_0000749

Removed

retinal bipolar neuron http://purl.obolibrary.org/obo/CL_0000748

Removed

Added

@aleixpuigb aleixpuigb requested a review from a user June 30, 2023 15:32
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider if it is more appropriate to place this axiom at the level of the parent class, CL:0000748 'retinal bipolar neuron'.

@aleixpuigb
Copy link
Collaborator Author

aleixpuigb commented Jul 3, 2023

Consider if it is more appropriate to place this axiom at the level of the parent class, CL:0000748 'retinal bipolar neuron'.

Thank you for the suggestion, I will add this axiom to 'retinal bipolar neuron' and remove from ON-bipolar cell.

As 'retinal neuron layer' had the EA 'bipolar neuron' and ('has soma location' some retina), all bipolar cells with soma in the retina would be classified under this class and therefore inherit 'has soma location' some 'inner nuclear layer of retina'. Therefore, it makes sense to substitute the EA to 'bipolar neuron' and ('has soma location' some 'inner nuclear layer of retina').

@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

@aleixpuigb aleixpuigb requested a review from a user July 3, 2023 13:35
@dosumis
Copy link
Contributor

dosumis commented Jul 3, 2023

I think moving the soma location axiom to the more general term makes sense from what I know of the biology. For a broader review of the biology - I've found this useful:

Euler, T., Haverkamp, S., Schubert, T., & Baden, T. (2014). Retinal bipolar cells: elementary building blocks of vision. Nature Reviews Neuroscience, 15(8), 507–519. https://doi.org/10.1038/nrn3783

@aleixpuigb aleixpuigb merged commit 77e37ff into master Jul 4, 2023
@aleixpuigb aleixpuigb deleted the 2049_Off-bipolar-cell branch July 4, 2023 09:51
@aleixpuigb aleixpuigb changed the title Fixes #2049 add soma location OFF-bipolar cell Fixes #2049 add has soma location 'retinal bipolar cell' Jul 5, 2023
@aleixpuigb aleixpuigb changed the title Fixes #2049 add has soma location 'retinal bipolar cell' Fixes #2049 add has soma location 'retinal bipolar neuron' Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-classhierarchy HuBMAP Needed/useful for HuBMAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Class hierarchy] retinal bipolar neuron 'has soma location' some 'inner nuclear layer of retina'
2 participants