Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skeletal tissue definition #134

Closed
wdahdul opened this issue Oct 15, 2012 · 3 comments
Closed

skeletal tissue definition #134

wdahdul opened this issue Oct 15, 2012 · 3 comments

Comments

@wdahdul
Copy link
Member

wdahdul commented Oct 15, 2012

Can we make the VSAO definition primary in Uberon?

VSAO: external_definition "A specialized form of connective tissue in which the extracellular matrix is firm, providing the tissue with resilience, and/or mineralized and that functions in mechanical and structural support.[VSAO]"^^string

current: Connective tissue that functions in mechanical and structural support. Definition ref 1: VSAO:0000015

Note the def ref 1 in uberon references VSAO but it doesn't have the exact VSAO definition.

@cmungall
Copy link
Member

The definition in Uberon:

Connective tissue that functions in mechanical and structural support.

Came from VSAO, and has been that way for all versions of VAO/VSAO here:

However, as you say, we have an external definition, which is your preferred one:

property_value: external_definition "A specialized form of connective tissue in which the extracellular matrix is firm, providing the tissue with resilience, and/or mineralized and that functions in mechanical and structural support.[VSAO]" xsd:string {ontology="VSAO", external_class="VSAO:0000015", date_retrieved="2012-08-14", source="GO_REF:0000034", source="PSPUB:0000170"}

Where did this come from, if not the main vertebrate_skeletal_anatomy.obo file or its predecessors? This had me stumped.

In fact it came from the embedded VSAO inside teleost_anatomy_VSAO_edit.obo. I used this file to slurp the external_definition tags for TAO, and it ended up pulling the embedded VSAO ones, some of which were more up to date than anything in the main VSAO files. I should have added a check here. Or added another qualifier for the file from which it was retrieved.

Anyway, I will make the preferred one the main definition.

@cmungall
Copy link
Member

Note I also added the developmental relations.

@wdahdul
Copy link
Member Author

wdahdul commented Oct 16, 2012

Hi Chris,

We updated the definition based on coauthor comments in the VSAO manuscript. I think the update was done to the version of VSAO in the vocab-releases folder, not the skeletal/obo folder. That's why you also see the def embedded in the TAO file.
We should be using the VSAO version in the vocab-releases folder for all referencing in uberon because it is the most up-to-date.
Thanks!

On Oct 15, 2012, at 4:58 PM, Chris Mungall wrote:

The definition in Uberon:

Connective tissue that functions in mechanical and structural support.
Came from VSAO, and has been that way for all versions of VAO/VSAO here:

http://phenoscape.svn.sourceforge.net/viewvc/phenoscape/trunk/vocab/skeletal/obo/
However, as you say, we have an external definition, which is your preferred one:

property_value: external_definition "A specialized form of connective tissue in which the extracellular matrix is firm, providing the tissue with resilience, and/or mineralized and that functions in mechanical and structural support.[VSAO]" xsd:string {ontology="VSAO", external_class="VSAO:0000015", date_retrieved="2012-08-14", source="GO_REF:0000034", source="PSPUB:0000170"}
Where did this come from, if not the main vertebrate_skeletal_anatomy.obo file or its predecessors? This had me stumped.

In fact it came from the embedded VSAO inside teleost_anatomy_VSAO_edit.obo. I used this file to slurp the external_definition tags for TAO, and it ended up pulling the embedded VSAO ones, some of which were more up to date than anything in the main VSAO files. I should have added a check here. Or added another qualifier for the file from which it was retrieved.

Anyway, I will make the preferred one the main definition.


Reply to this email directly or view it on GitHub.

cmungall added a commit that referenced this issue Oct 16, 2012
    fixes #134
    updated EFO xrefs
    various placode and ganglion fixes
    metadata
    edits from obo-anatomy call. More specific skeletal relation for metacarpals. syn for preax/postax
    Fixes #131
    more pedal digits
    pedal digitl precusors synonyms
    documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants