Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on uberon.makefile ln100 #2233

Closed
shawntanzk opened this issue Jan 12, 2022 · 6 comments
Closed

Error on uberon.makefile ln100 #2233

shawntanzk opened this issue Jan 12, 2022 · 6 comments
Assignees
Labels

Comments

@shawntanzk
Copy link
Collaborator

$(OWLSRC): tmp/uberon-merged.owl $(COMPONENTSDIR)/disjoint_union_over.ofn $(REPORTDIR)/$(SRC)-gocheck $(REPORTDIR)/$(SRC)-iconv $(SCRIPTSDIR)/expand-dbxref-literals.pl
	echo "STRONG WARNING: issues/contributor.owl needs to be manually updated."
	$(OWLTOOLS) --no-logging $< $(COMPONENTSDIR)/disjoint_union_over.ofn issues/contributor.owl --merge-support-ontologies --expand-macros -o  $@ &&  $(SCRIPTSDIR)/expand-dbxref-literals.pl $@ > $@.tmp
	$(ROBOT) query -i $@.tmp --update $(SPARQLDIR)/taxon_constraint_never_in_taxon.ru --update $(SPARQLDIR)/remove_axioms.ru -o $@ \
           query --update ../sparql/delete-definition-dot.ru merge -i imports/ro_import.owl -o $@

The above is the command in the makefile where it is failing.

tmp/uberon-merged.owl seems to be built alright, but seems to be failing at the line that starts with $(OWLTOOLS)

make: *** [uberon.Makefile:100: tmp/uberon-edit.owl] Error 1

This is the same failure with trying to build imports and mirrors and trying to make tmp/uberon-edit.owl

making tmp/uberon-merged.owl is fine though

@shawntanzk
Copy link
Collaborator Author

full documentation of this: #2231 (comment)

@dosumis
Copy link
Contributor

dosumis commented Jan 12, 2022

This is sufficient to prompt the error:

./run.sh owltools tmp/uberon-merged.owl --expand-macros
(assuming tmp/uberon-merged.owl is built).

hypothesis - this is caused by an issue in never_in_taxon AP axioms that have changed since the last release

@shawntanzk can you do a diff of uberon-edit.owl since the last release and grep the results for never_in_taxon to see if any look odd?

@shawntanzk
Copy link
Collaborator Author

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/Users/shawntan/Documents/GitHub/uberon/src/ontology/tmp.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/Users/shawntan/Documents/GitHub/uberon/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

UBERON_8410068 http://purl.obolibrary.org/obo/UBERON_8410068

Added

echolocation organ http://purl.obolibrary.org/obo/UBERON_0010053

Added

exoskeleton http://purl.obolibrary.org/obo/UBERON_0006611

Added

feather http://purl.obolibrary.org/obo/UBERON_0000022

Added

fimbria of uterine tube http://purl.obolibrary.org/obo/UBERON_8410010

Removed

Added

laminar subdivision of the cortex http://purl.obolibrary.org/obo/UBERON_8440004

Added

peripheral nervous system http://purl.obolibrary.org/obo/UBERON_0000010

Removed

@shawntanzk
Copy link
Collaborator Author

@dosumis not sure how to grep with old version and all, but the above is the diff between the last uberon release and current, the following are the ones that have never in taxon:

echolocation organ http://purl.obolibrary.org/obo/UBERON_0010053
Added
echolocation organ never_in_taxon "Euarchontoglires"^^string
exoskeleton http://purl.obolibrary.org/obo/UBERON_0006611
Added
exoskeleton never_in_taxon "Euarchontoglires"^^string
feather http://purl.obolibrary.org/obo/UBERON_0000022
Added
feather never_in_taxon "Euarchontoglires"^^string

@dosumis
Copy link
Contributor

dosumis commented Jan 12, 2022

Values should be classes, not strings! Fixing now.

dosumis added a commit that referenced this issue Jan 12, 2022
shawntanzk added a commit that referenced this issue Jan 24, 2022
shawntanzk added a commit that referenced this issue Jan 24, 2022
Related to #2233
Think it fixes the error - need to try before I close
@shawntanzk
Copy link
Collaborator Author

Fixed in #2248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants