Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3043 NTR neuroendocrine system #3045

Merged
merged 5 commits into from
Sep 4, 2023

Conversation

aleixpuigb
Copy link
Collaborator

Closes #3043 NTR neuroendocrine system

Closes #3043 NTR neuroendocrine system
@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

@github-actions
Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2023-08-29/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2023-08-29/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/uberon-simple.owl

Ontology imports

Ontology annotations

neuroendocrine system http://purl.obolibrary.org/obo/UBERON_8600018

Added

@github-actions
Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

neuroendocrine system http://purl.obolibrary.org/obo/UBERON_8600018

Added

@aleixpuigb aleixpuigb requested a review from a user August 29, 2023 13:29
[Term]
id: UBERON:8600018
name: neuroendocrine system
def: "A regulatory system of the body that integrates the nervous system and the endocrine system. This system consists of a set of cells organized in single organs and diffuse elements, sharing co-production of amine hormone/transmitters, peptide hormone/transmitters and specific markers of neural determination." [PMID:15481802, Wikipedia:endocrinology]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the term "neurohormone" as the current definition does not capture all neurohormones (e.g., steroid hormones).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider the following definition, although I haven't found no-cost access to the online reference:

Neuroendocrine systems can be defined as the sets of neurons, glands and non-endocrine tissues, and the neurochemicals, hormones, and humoral signals they produce and receive, that function in an integrated manner to collectively regulate a physiological or behavioral state.
From: Handbook of Neuroendocrinology, 2012

Copy link
Collaborator Author

@aleixpuigb aleixpuigb Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comments and providing this reference.
The new updated definition is the following:

A regulatory system of the body that integrates the nervous system and the endocrine system. This system involves specialized neuroendocrine cells primarily located in the hypothalamus, pituitary gland, and various organs. The neuroendocrine system functions through the release of neurotransmitters and hormones, enabling communication between these systems to govern vitally important processes that include growth, reproduction, metabolism and energy homeostasis, electrolyte and water balance, and responses to stress.

https://doi.org/10.1016/B978-0-12-375097-6.10001-0
PMID:15481802
Wikipedia:endocrinology

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second sentence: "involves" and "various organs" are vague.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider text definition revision.
Consider more expansive curation- currently there is no relation to more obvious structures (e.g., 'neuroendocrine gland', 'neuroendocrine cell').

@aleixpuigb aleixpuigb requested a review from a user August 31, 2023 14:39
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing curation: missing relationship to 'neuroendocrine gland', neuroendocrine cell types, etc. If there is a related CL ticket to address cell types, please add link.

[Term]
id: UBERON:8600018
name: neuroendocrine system
def: "A regulatory system of the body that integrates the nervous system and the endocrine system. This system involves specialized neuroendocrine cells primarily located in the hypothalamus, pituitary gland, and various organs. The neuroendocrine system functions through the release of neurotransmitters and neurohormones, enabling communication between these systems to govern vitally important processes that include growth, reproduction, metabolism and energy homeostasis, electrolyte and water balance, and responses to stress." [doi:10.1016/B978-0-12-375097-6.10001-0, PMID:15481802, Wikipedia:endocrinology]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beware that this definition (specifically the part “involves […] cells primarily located in the hypothalamus, pituitary gland, and various organs”) makes the term vertebrate-specific. Invertebrates may lack a hypothalamus or a pituitary gland but they do have a “neuroendocrine system” (see for example Hartenstein 2006), so if it is intended that this term should be vertebrate-specific then this should be clearly stated; otherwise the definition should avoid referring to vertebrate-specific structures or at least use precautions around them.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gouttegd, the intention is that is not vertebrate-specific, and anything that is vertebrate-specific will be in a comment.

@aleixpuigb
Copy link
Collaborator Author

The definition has been updated to be more general to non-vertebrates species and not be vague (although I don't want to list the tissues that also have neuroendocrine cells, as that is variable depending on the species).

Still missing curation: missing relationship to 'neuroendocrine gland', neuroendocrine cell types, etc. If there is a related CL ticket to address cell types, please add link.

relationships have been added. Once this ticket is merged and uberon has a new release, this term will be imported to CL to add neuroendocrine cell SubclassOf part_of 'neuroendocrine system to address this CL ticket.

@aleixpuigb aleixpuigb requested a review from a user September 1, 2023 13:17
relationship: has_part CL:0000165 ! neuroendocrine cell
relationship: overlaps UBERON:0001016 ! nervous system
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the updated logical definition, would this be redundant?

Copy link
Collaborator Author

@aleixpuigb aleixpuigb Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. If K overlaps T, that means there is C that is the overlapping part. If B is part of K, it does not mean that it is part of C (overlapping T).
For clarification I have added a diagram and changed the letters:
image

Copy link

@ghost ghost Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a plan to revise 'neuroendocrine cell'?
If not, this may still be redundant if keeping 'has part' some 'neuroendocrine cell'.

Screenshot 2023-09-01 at 15 16 26

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, neuroendocrine cell will not be a neuron after the revision.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No breaking changes.

@aleixpuigb aleixpuigb merged commit d84c99b into master Sep 4, 2023
1 check passed
@aleixpuigb aleixpuigb deleted the 3043_NTR_neuroendocrine_system branch September 4, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NTR] neuroendocrine system
2 participants