Fixed all parameters optional #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obophp
reviewed
Jul 7, 2017
src/Annotation/Base/Definition.php
Outdated
| @@ -108,18 +109,22 @@ public function checkAnnotationValueStructure($annotationValue) { | |||
| */ | |||
| private function checkNumberOfParametersForAnnotationValue($annotationValue) { | |||
| $parametersDefinition = static::parametersDefinition(); | |||
| $definitionValue = $parametersDefinition[self::PARAMETERS_NUMBER_DEFINITION]; | |||
| if (!\is_numeric($definitionValue) AND $definitionValue !== self::ZERO_OR_ONE_PARAMETER) { | |||
| throw new \obo\Exceptions\BadAnnotationException("Bad '" . self::PARAMETERS_NUMBER_DEFINITION . "' definition"); | |||
LukeArthur
force-pushed
the
lk-37456
branch
2 times, most recently
from
65fefec
to
c05d626
Compare
Fixed all parameters optional in annotation definition for PARAMETERS_DEFINITION structure
hAdamm
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed all parameters optional in annotation definition for PARAMETERS_DEFINITION structure