Relax the Range on RO_0002295 #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the range of RO to be anatomical entity instead Related to obophenotype/cell-ontology#1782 (see CL ticket for reason)
|
The definition should be corrected as well, so that it no longer refers to an anatomical structure. |
|
I am happy to put this on the agenda for the next RO meeting. Can you please hold off merging until then? |
|
I think this is good to merge, once Damien's comments are incorporated
(this could even go in a separate PR)
…On Fri, Dec 23, 2022 at 7:28 AM Bill Duncan ***@***.***> wrote:
I am happy to put this on the agenda for the next RO meeting. Can you
please hold off merging until then?
—
Reply to this email directly, view it on GitHub
<#659 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMMOP6MF6MIK5NANL5EW3WOXAIDANCNFSM6AAAAAATHY26MA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Already incorporated :)
Alright, will merge, no need for taking up time in RO meeting then :) Thanks @cmungall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the range of RO to be anatomical entity instead
Related to obophenotype/cell-ontology#1782 (see CL ticket for reason)
Thanks to @gouttegd & @bvarner-ebi