Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a full option to Input.search for searching the whole text #226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

john-guerra
Copy link

The current Input.Search, won't return values where the string is not at the beginning

viewof old = Inputs.search(["Control", "BallControl"], { query: "con" }) // IMHO should return two results

I propose either adding a full parameter that can be set to true if one wants this behaviour

viewof propossed = Inputs.search(["Control", "BallControl"], {
  query: "con",
  full: true
}) // Returns two results

see: https://observablehq.com/d/0645386b5b3c5499

@mootari
Copy link
Member

mootari commented Oct 30, 2022

@john-guerra Committing yarn.lock was probably an accident?

@john-guerra
Copy link
Author

Yes, by accident

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants