Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marginRight in y facet does not translate label of x #375

Closed
EE2dev opened this issue May 10, 2021 · 2 comments · Fixed by #1197
Closed

marginRight in y facet does not translate label of x #375

EE2dev opened this issue May 10, 2021 · 2 comments · Fixed by #1197
Labels
bug Something isn’t working

Comments

@EE2dev
Copy link
Contributor

EE2dev commented May 10, 2021

Observed when I applying facet y on a dot plot:

When I change marginRight within the facet y object,
it updates the dot plot and the x axis with the ticks (as expected) but does not translate the label of x to the new end of the axis

image

(see the age label in: https://observablehq.com/d/1d9e39bd4f83a69a)
@mbostock mbostock added the bug Something isn’t working label May 11, 2021
Fil added a commit that referenced this issue May 14, 2021
@Fil
include margins in the label translate
71ed111 
fixes #375
@Fil Fil mentioned this issue May 14, 2021
Closed
Fil added a commit that referenced this issue Aug 18, 2021
@Fil
include margins in the label translate
2bf5776 
fixes #375
Fil added a commit that referenced this issue Aug 19, 2021
@Fil
include margins in the label translate
bcecaef 
fixes #375
@mbostock
Copy link
Member

mbostock commented Dec 1, 2022

We tried to fix this in #402 but I think we should take another crack at it.

@mbostock mbostock mentioned this issue Dec 1, 2022
Open
mbostock added a commit that referenced this issue Jan 26, 2023
@mbostock
fix #375; respect facet margins
d7fc5a7
@mbostock mbostock mentioned this issue Jan 26, 2023
Merged
36 tasks
@EE2dev
Copy link
Contributor Author

EE2dev commented Feb 1, 2023

👍

@Fil Fil mentioned this issue Sep 14, 2023
Open
6 tasks
@severo severo mentioned this issue Jan 12, 2024
Open
chaichontat pushed a commit to chaichontat/plot that referenced this issue Jan 14, 2024
@mbostock @Fil @chaichontat
axis mark (observablehq#1197)
3db1557 
* axis mark

* deferred channels

* vector tick

* tickPadding

* grid

* grid

* no rounded stroke

* fix half-pixel offset

* more conditional axes

* grid mark

* DRY tick

* tick[XY]

* explicit ticks

* axisTick[XY]

* axis mark data

* axis insets

* tickFormat

* better default tick format

* simpler inferTickFormat

* auto ticks; expose scale.interval

* anchor

* manual axis label, for now

* tickRotate

* fix crash in sparse excludeIndex

* facetAnchor; fix mark-level missing facet

* simpler facet sorting

* fix observablehq#522; better facetAnchor

* fix observablehq#1198; better empty facets

* fix for ordinal scales

* soft hyphen

* test label wrapping

* facet grid

* better facet grid

* better facet grid, again

* better grid

* better facet axes; fix font variant

* extract facetSkip

* empty facets

* destructure options

* remove redundant defaults

* fix tickPadding, tickRotate

* better grid defaults

* more empty facets

* simpler facet warning

* decoration

* better empty facets

* better facet sort

* extract facetAnchor

* extract more facet logic

* const facets

* unify code

* more facet anchors

* invert facetAnchor

* checkpoint axis label

* checkpoint axis mark integration

* fix minimum offset margin

* fix for null marks and scales

* better implicit axes

* denote side-effect

* better axis options

* implicit facet axes

* more implicit axis options

* inferAxes

* delete old axes

* minimize diff

* fix default margins

* remove mark.decoration

* facet margin options

* move side effect

* inheritScaleLabels

* remove comment

* better ARIA labels; restore prior axis order

* regenerate tests; smarter partial implicit axes

* more smarter partial implicit axes

* axis line

* text stroke options

* don’t inline text elements

* do inline title elements

* axis label

* fix axes for interval scales

* gridDasharray

* better implicit axis

* x-axis label

* another fancy axis example

* polish example

* fancy multi-line time ticks

* another fancy axis example

* remove secondary grid shorthand

* tweak y-axis label position

* first stab at documentation

* the grid doesn't follow anchor

* better deferred channels

* better explicit built-in axes

* fix metroUnemploymentRidgeline test

* use insetTop for better semantics

* fix label option inheritance

* axis = both

* fix comment

* a few fixes to axis label position

* labelAnchor

* smarter default labelAnchor

* fix googleTrendsRidgeline

* fix longLabels

* non-fix for named time intervals

* fix projectionHeightGeometry

* non-fix for x-axis label position

* better axis label position

* inset axis label

* fix observablehq#375; respect facet margins

* fix industryUnemploymentTrack

* restore grid in penguinCulmen

* facet margin collapse

* better facet margin collapse

* drop comment

* labelOffset

* fix auto labels and arrows

* named exports for tests

* enable facet axis labels

* add non-faceted athletesSample test

* better facet axis label position

* cleaner

* enforce constant tick options

* shorter athletesSportWeight

* remove dead code

* checkpoint cross-facet marks

* checkpoint supermarks

* super option

* better super marks

* drop unused mid facet anchors

* disallow superposition, for now

* facet = super

* minimize diff

* fix axis label position, finally?

* better hexbin tests

* polish tests

* fix named time intervals for ticks

* grid xy shorthand

* consistent scale checks

* better axis options

* tickSpacing option

* propagate tickSpacing option

* fix off-by-one with interval ticks

* typo (thanks, @yurivish!)

* only one label for both axes

* a bit of documentation for axisX

* given data, don’t defer channels

* reduce aaplCloseDataTicks test

* implicit grid with explicit axis

* more grid shorthand

* Update README

* fix default facet axis anchor

* axis plot shorthand

* Update README

---------

Co-authored-by: Philippe Rivière <fil@rezo.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn’t working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

axis mark observablehq/plot
include margins in the label translate observablehq/plot
2 participants
@mbostock @EE2dev