Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts defs #1001

Closed
wants to merge 23 commits into from
Closed

ts defs #1001

wants to merge 23 commits into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Jul 19, 2022

bugs fixed:

  • Plot.valueof(undefined, () => {}) crashed
  • Plot.map("foo") crashed
  • Plot.selectMinX potentially inserted undefined in the facet index
  • mid(x1, x2) was wrongly typed (it expected a data argument)

@Fil Fil requested a review from duaneatat July 19, 2022 13:21
@duaneatat
Copy link
Contributor

will take a look asap! let's merge into main though, the ts-testing branch is just a temporary branch

@Fil Fil changed the base branch from ts-testing to main July 21, 2022 15:45
@Fil
Copy link
Contributor Author

Fil commented Jul 21, 2022

rebased on main

@Fil
Copy link
Contributor Author

Fil commented Jul 22, 2022

I'm going to reboot this. I want the names and the autocomplete to match the API documentation exactly.

For a low-level example I want to type an index into a channel as index and channel, not as number and any[]. I want to remove nullish and be explicit about the difference between null and undefined.

For a high level example, a Dot mark options object will be DotOptions and explicitly list all the fields that make sense for dots. I just need to figure out how to make that an extension of a common MarkOptions object.

@Fil Fil closed this Jul 22, 2022
@Fil Fil mentioned this pull request Jul 23, 2022
7 tasks
@Fil Fil deleted the fil/ts branch July 26, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants