Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix facetAnchor interactive doc crashing when it receives "null" #1974

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix facetAnchor interactive doc crashing when it receives "null" #1974

merged 1 commit into from
Jan 15, 2024

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Jan 15, 2024

closes #1972

@Fil Fil requested a review from mbostock January 15, 2024 19:27
@Fil Fil enabled auto-merge (squash) January 15, 2024 19:27
mbostock
mbostock approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Fil Fil merged commit 48b71d7 into main Jan 15, 2024
1 check passed
@Fil Fil deleted the fil/fix-1972 branch January 15, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation page about axis mark turns empty if an interactive selection is made
2 participants
@Fil @mbostock