-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d3 7.9.0 #2020
d3 7.9.0 #2020
Conversation
Should we not bump this dependency to 7.9.0? To guarantee d3.schemeObservable10? "dependencies": { |
The 5 tests that change are expected (and welcome… better geo circles). |
I'm still unsure if this works!? in a notebook if I try to import 031cecf: Plot = import("https://esm.sh/gh/observablehq/plot@031cecfb4de3863403dd7ec67db4c48219de415b") it errors like so:
That's because esm.sh is content with using |
Oh, yeah, that’s probably a bug. |
Well, hold on, that’s always true of D3’s package.json. So I think that’s just an esm.sh issue. |
This is a bit over my head… 🤷🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also tested with Framework: /_npm/d3@7.9.0/+esm.js references the correct version of scale-chromatic.
Relevant history is d3/d3#3256. |
interesting! I think the answer to my question is https://classic.yarnpkg.com/en/docs/selective-version-resolutions/#toc-how-to-use-it
(still only for yarn users, though) |
I think I encountered the same problem. I updated
I fixed it by (temporarily) adding a direct dependency to |
No description provided.