Propagate rules client status code #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Merged
matej-g
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Thanks for swiftly jumping in @saswatamcode! I'm wondering whether we should add a test case for this in here or still in #198 🤔. Maybe we could finally merge the tests PR, rebase this PR and add the test / remove TODO as part of this?
|
Yes, the test can be added here once the rule tests PR is merged! 🙂 |
matej-g
reviewed
Jan 25, 2022
squat
approved these changes
Jan 25, 2022
|
@saswatamcode awesome! I'll re-add the test in #198 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the API returns 200 status codes for all responses of the rules client. So even if the rules file in a PUT request is invalid, API returns 200 with the body
request body failed rule group validationas observed in #198.This PR ensures that the correct HTTP status code received from the rules client is propagated by the API, for the
rules/rawendpoint.Fixes MON-2176.