Allow WebsocketInitFunc to add payload to Ack #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telemenar
force-pushed
the
addConnectionAckPayload
branch
from
68373bb
to
686fd40
Compare
Pull Request Test Coverage Report for Build 6127014767
💛 - Coveralls |
The connection ACK message in the protocol for both graphql-ws and graphql-transport-ws allows for a payload in the connection ack message. We really wanted to use this to establish better telemetry in our use of websockets in graphql.
telemenar
force-pushed
the
addConnectionAckPayload
branch
from
686fd40
to
12afb29
Compare
Pull Request Test Coverage Report for Build 6127045929
💛 - Coveralls |
observe-ryan
approved these changes
Sep 12, 2023
telemenar
added a commit
that referenced
this pull request
Sep 29, 2023
* Allow WebsocketInitFunc to add payload to Ack The connection ACK message in the protocol for both graphql-ws and graphql-transport-ws allows for a payload in the connection ack message. We really wanted to use this to establish better telemetry in our use of websockets in graphql. * Fix lint error in test * Switch argument ordering. --------- Co-authored-by: Chris Pride <cpride@observeinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connection ACK message in the protocol for both graphql-ws and graphql-transport-ws allows for a payload in the connection ack message.
We really wanted to use this to establish better telemetry in our use of websockets in graphql.
Describe your PR and link to any relevant issues.
I have: