Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--masked shouldn't be an option #8

Open
aaugustin opened this issue Nov 3, 2014 · 2 comments
Open

--masked shouldn't be an option #8

aaugustin opened this issue Nov 3, 2014 · 2 comments

Comments

@aaugustin
Copy link

https://tools.ietf.org/html/rfc6455#section-5.1 says:

a client MUST mask all frames that it sends to the server

So I don't understand why masking is an option in the Thor client and even less why it's disabled by default.

I came across this issue while investigating python-websockets/websockets#36.
@aaugustin aaugustin mentioned this issue Nov 3, 2014
Closed
@ztellman
Copy link

This also bit me.

@aaugustin
Copy link
Author

Without response after a year, it doesn't seem worth keeping this in my list of open issues.

reda-alaoui added a commit to Cosium/thor that referenced this issue Jan 9, 2016
@reda-alaoui
observing#8 --masked shouldn't be an option
d507d7b
@reda-alaoui reda-alaoui mentioned this issue Jan 9, 2016
Closed
reda-alaoui added a commit to Cosium/thor that referenced this issue Jan 9, 2016
@reda-alaoui
observing#8 --masked shouldn't be an option
796ae22 
(cherry picked from commit d507d7b)
reda-alaoui added a commit to Cosium/thor that referenced this issue Jan 9, 2016
@reda-alaoui
observing#8 --masked shouldn't be an option
731aeb8 
(cherry picked from commit d507d7b)
@Nibbler999 Nibbler999 mentioned this issue Aug 30, 2017
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ztellman @aaugustin