New Note: Best Practices and Tips for Theme Development #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm curious that the PR template is not showing up in recent PRs... Are you removing the text, or is it not working any more? |
|
@SlRvb Hi, would you be OK to review this one please? I don't feel qualified! |
|
oh, I simply removed it for the sake of briefness, as I was basically making mini-PRs where the checklist doesn't really apply. Sorry, in principle I should still fill stuff out 🙏 |
|
It helps reviewers to know that you have done the things... Like, when I first reviewed this, there wasn't a link added to the new file... |
|
So the last checkbox does apply! |
|
Anyways, not a big deal - and thanks for adding the link 🎉 |
kometenstaub
requested changes
Dec 30, 2021
04 - Guides, Workflows, & Courses/Guides/Best Practices and Tips for Theme Development
Outdated
Show resolved
Hide resolved
…s and Tips for Theme Development Co-authored-by: kometenstaub <83140328+kometenstaub@users.noreply.github.com>
kometenstaub
approved these changes
Dec 30, 2021
SlRvb
requested changes
Dec 30, 2021
04 - Guides, Workflows, & Courses/Guides/Best Practices and Tips for Theme Development
Outdated
Show resolved
Hide resolved
…ps for Theme Development Co-authored-by: SlRvb <54087190+SlRvb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added note and linked it in the theme designers MoC
Checklist
04 - Guides, Workflows, & Courses, I added a link to the new note(s) in one of thefor {group X}overviews (listed here).