obsidian-reminders modal #432

ZibraMax · 2021-11-27T06:33:39Z

I love this plugin, I've been using it for a long time. It has almost everything that I wanted from obsidian (I came from a Notion environment), however, I wanted to have reminders for my tasks.

Using the workaround described here, I decided to modify the modal when creating/editing task with an option to add a reminder from obsidian-reminder plugin.

It uses the alarm clock emoji, the panel now looks like this:

The created task looks like this:

And the reminders plugin automatically recognizes the task as reminder:

As not everybody uses obsidian-reminders, I added an option to hide the reminders input in the create/edit task modal. It is hidden by default:

If it is false, it leaves the modal as before.

Thanks for this awesome plugin, I hope you like this.

schemar · 2021-11-28T12:18:25Z

Thank you so much @ZibraMax! I am busy right now, so please be patient.

joellti · 2021-12-15T16:53:09Z

@ZibraMax I did a test of this PR and it works really well but one thing I notice is that the calendar modal that picks reminder date/time is not appearing when the plugin is running on Obsidian mobile version (Android to be specific). I think it's important to make it work on mobile devices since typing date/time is more inefficient than PCs. So hope it will be addressed. Thx

schemar · 2022-02-13T10:31:25Z

Thank you for the update @ZibraMax! I haven't forgotten about you.

ZibraMax · 2022-02-13T14:16:23Z

Hi!

Sorry for the late reply, college leaves no time.

The calendar modal option was a test. It was not intended in the original idea of the reminder option.

I think the modal not working on android depends on the android version (mine is 11, and it works fine). But the position of the calendar button changes.

As a future improvement, the calendar modal can be achieved by using the calendar plugin ui. This may be the topic of a future PR :)

Thanks for your response and your time!

schemar · 2022-04-06T17:21:41Z

You weren’t forgotten! I had to cut a release to finally get live preview out of the door.

claremacrae

This is really good. Thank you very much indeed for doing it.

A number of the comments below are reminders for me, when I merge this in.
But there are a few questions mixed in, if you have time to look at them.

claremacrae · 2022-06-11T10:22:45Z

src/Settings.ts

@@ -1,11 +1,13 @@
 export interface Settings {
    globalFilter: string;
    removeGlobalFilter: boolean;
+    reminder: boolean; //To activate the reminder input


I will probably rename this to something that removes the need for a comment, perhaps remindersEnabled or remindersActivated

claremacrae · 2022-06-11T10:24:52Z

src/SettingsTab.ts

+
+        containerEl.createEl('div', {
+            cls: 'setting-item-description',
+            text: 'Enable reminder on edit/create task (requires obsidian-reminder plugin)',


Does it actually require the reminder plugin, or is it there is only really any benefit of you are using the reminders plugin?

(By which I mean, do we need to add code to check if the reminders plugin is enabled?)

Is obsidian-reminder the plugin id? Would it be better to use the plugin name that users will see in the Plugin store?

claremacrae · 2022-06-11T10:25:24Z

src/SettingsTab.ts

+        new Setting(containerEl)
+            .setName('Enable reminder on edit/creat task')
+            .setDesc(
+                'Enable reminder on edit/create task (requires obsidian-reminder plugin)',


There seems to be some duplicated text here: Enable reminder on edit/create task (requires obsidian-reminder plugin)

I may refactor it out to create a variable for the duplicated text.

claremacrae · 2022-06-11T10:25:43Z

src/SettingsTab.ts

+        });
+
+        new Setting(containerEl)
+            .setName('Enable reminder on edit/creat task')


Typo: creat -> create

claremacrae · 2022-06-11T10:26:58Z

src/Task.ts

@@ -77,6 +80,7 @@ export class Task {
        doneDate,
        recurrence,
        blockLink,
+        reminderTime, //reminder attribute, same as dueDate but with time


I might rename this to reminderDateTime, to make it clear that it includes a date as well. Not sure about that though.

In general, it's good to make the names clear enough that comments are not needed, especially in view of how many times this comment is repeated further down.

claremacrae · 2022-06-11T10:28:08Z

src/Task.ts

        // Add a "max runs" failsafe to never end in an endless loop:
-        const maxRuns = 7;
+        const maxRuns = 10;


@ZibraMax Can you remember why you increased maxRuns please?

claremacrae · 2022-06-11T10:30:11Z

src/Task.ts

@@ -363,6 +384,13 @@ export class Task {
    public toString(layoutOptions?: LayoutOptions): string {
        layoutOptions = layoutOptions ?? new LayoutOptions();
        let taskString = this.description;
+        //Reminder can't be inshort mode, otherwise obsidian-reminder won't work!!!!


The short mode is only ever used for displaying the text in Tasks results blocks.

When Tasks writes tasks out as Markdown, it always writes all fields.

Therefore, I think a new option to hide reminders should be added, for display purposes. I can do this as a separate pull request though.

claremacrae · 2022-06-11T10:32:11Z

src/ui/EditTask.svelte

        };
+        //Only load reminder panel if activated in settings
+        const { reminder } = getSettings();
+        if (!reminder) {


Why !reminder - why the negation?

Oh, the comment says 'only load' but I think that what the code is doing suggests that the comment should say something like Remove the reminder panel if not activated in settings

claremacrae · 2022-06-11T10:37:07Z

Before merging this, I have to figure out how to safely resolve merge conflicts, whilst still retaining the original author identity of the original commits.

Erik-Handeland · 2023-04-07T06:27:02Z

Any update on this PR? I ended up just modifying my installation of the reminder plugin to use the ⏳ emoji instead of ⏰ but would love to have something native with time support no less. Didn't see this on the Tasks (Obsidian plugin) Roadmap so just wanted to check on this.

--Edit

Looks like the code base has changed quite a bit since the PR was created. Merging it in after the refactoring is probably not a trivial task

claremacrae · 2023-04-09T16:30:27Z

Any update on this PR? I ended up just modifying my installation of the reminder plugin to use the ⏳ emoji instead of ⏰ but would love to have something native with time support no less. Didn't see this on the Tasks (Obsidian plugin) Roadmap so just wanted to check on this.

Given the number of data-loss issues encountered by people using Reminders with Tasks, at the moment I feel I wouldn't want to encourage Tasks users to use Reminders...

See the warnings here, and multiple comments on the linked issue:
https://publish.obsidian.md/tasks/Advanced/Notifications

Erik-Handeland · 2023-04-09T18:01:18Z

Given the number of data-loss issues encountered by people using Reminders with Tasks, at the moment I feel I wouldn't want to encourage Tasks users to use Reminders...

See the warnings here, and multiple comments on the linked issue: https://publish.obsidian.md/tasks/Advanced/Notifications

I see, I think task notifications are a really key aspect of task management. I'm sure a lot of the issues from the reminders plugin comes from Tasks integration being a secondary feature and not the main consideration when creating the original plugin. I'm thinking of recreating the feature set in Tasks. Are there any dev docs published some where? Skimming through some of the PR, I saw that there is a tasks apiV1. If I end up finding the time to create a reminders like feature would it be possible to having something natively integrated or is using the apiV1 through a separate plugin the preferred way to interact with tasks.

claremacrae · 2023-04-09T22:11:01Z

I'm sure a lot of the issues from the reminders plugin comes from Tasks integration being a secondary feature and not the main consideration when creating the original plugin.

I do think that is very likely to be true.

I'm thinking of recreating the feature set in Tasks.

Interesting.

If you decide to go ahead, it would be a good idea for us to have a chat before you start work on it, to consider approaches that you might take.

It would save us both a lot of time - you from having to figure stuff out, and me from reviewing code where perhaps I could have given you pointers from the outset, and then you from potentially reworking stuff! 😄

We would also talk about how it could be written with automated tests.

My email is my profile here.

Are there any dev docs published some where?

https://publish.obsidian.md/tasks-contributing/

Skimming through some of the PR, I saw that there is a tasks apiV1. If I end up finding the time to create a reminders like feature would it be possible to having something natively integrated or is using the apiV1 through a separate plugin the preferred way to interact with tasks.

I don't have enough to be able to talk about that. That would be a good thing to add to the list of things to discuss directly! 😃

claremacrae · 2023-04-09T23:15:49Z

Skimming through some of the PR, I saw that there is a tasks apiV1. If I end up finding the time to create a reminders like feature would it be possible to having something natively integrated or is using the apiV1 through a separate plugin the preferred way to interact with tasks.

Now I think I understand.

Don’t worry about the API. Just think about the feature from the perspective of a Tasks user.

claremacrae · 2023-04-09T23:17:37Z

One thing I forgot to say earlier.

We must be mindful of respecting the license of any ideas or code from Reminders.

Both plugins are MIT so the licence is compatible. But we would need to be sure that any terms like giving credit or whatever are respected.

Erik-Handeland · 2023-04-09T23:32:28Z

Now I think I understand.

Don’t worry about the API. Just think about the feature from the perspective of a Tasks user.

Perfect, I've created a new issue to get some input on the overall design aspect #1854 well reach out via email for my thoughts on the code implementation

claremacrae · 2023-04-10T08:08:28Z

Hi @ZibraMax, many thanks for offering this code, and apologies that it was never merged in to Tasks.
Following the recent discussion, I'll close this now, and discussion will continue in #1854.

ZibraMax added 3 commits November 27, 2021 01:11

Obsidian-reminders support

807e7f7

reminder modal

409a438

Test string changed

923314e

ZibraMax force-pushed the main branch from 7d96867 to 923314e Compare February 13, 2022 03:55

claremacrae reviewed Jun 11, 2022

View reviewed changes

claremacrae mentioned this pull request Jun 26, 2022

[Bug]: recurring logic gives wrong dates uphy/obsidian-reminder#93

Closed

Erik-Handeland mentioned this pull request Apr 9, 2023

Native reminder support #1854

Closed

2 tasks

claremacrae closed this Apr 10, 2023

claremacrae added scope: reminders Showing a reminder to do a task scope: task dates and times Requests for enhancements to types and formats of dates and times associated with tasks labels Apr 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

obsidian-reminders modal #432

obsidian-reminders modal #432

ZibraMax commented Nov 27, 2021

schemar commented Nov 28, 2021

joellti commented Dec 15, 2021

schemar commented Feb 13, 2022

ZibraMax commented Feb 13, 2022

schemar commented Apr 6, 2022

claremacrae left a comment

claremacrae Jun 11, 2022

claremacrae Jun 11, 2022

claremacrae Jun 11, 2022 •

edited

Loading

claremacrae Jun 11, 2022

claremacrae Jun 11, 2022

claremacrae Jun 11, 2022

claremacrae Jun 11, 2022

claremacrae Jun 11, 2022

claremacrae commented Jun 11, 2022

Erik-Handeland commented Apr 7, 2023 •

edited

Loading

claremacrae commented Apr 9, 2023

Erik-Handeland commented Apr 9, 2023

claremacrae commented Apr 9, 2023

claremacrae commented Apr 9, 2023

claremacrae commented Apr 9, 2023

Erik-Handeland commented Apr 9, 2023

claremacrae commented Apr 10, 2023

obsidian-reminders modal #432

obsidian-reminders modal #432

Conversation

ZibraMax commented Nov 27, 2021

schemar commented Nov 28, 2021

joellti commented Dec 15, 2021

schemar commented Feb 13, 2022

ZibraMax commented Feb 13, 2022

schemar commented Apr 6, 2022

claremacrae left a comment

Choose a reason for hiding this comment

claremacrae Jun 11, 2022

Choose a reason for hiding this comment

claremacrae Jun 11, 2022

Choose a reason for hiding this comment

claremacrae Jun 11, 2022 • edited Loading

Choose a reason for hiding this comment

claremacrae Jun 11, 2022

Choose a reason for hiding this comment

claremacrae Jun 11, 2022

Choose a reason for hiding this comment

claremacrae Jun 11, 2022

Choose a reason for hiding this comment

claremacrae Jun 11, 2022

Choose a reason for hiding this comment

claremacrae Jun 11, 2022

Choose a reason for hiding this comment

claremacrae commented Jun 11, 2022

Erik-Handeland commented Apr 7, 2023 • edited Loading

claremacrae commented Apr 9, 2023

Erik-Handeland commented Apr 9, 2023

claremacrae commented Apr 9, 2023

claremacrae commented Apr 9, 2023

claremacrae commented Apr 9, 2023

Erik-Handeland commented Apr 9, 2023

claremacrae commented Apr 10, 2023

claremacrae Jun 11, 2022 •

edited

Loading

Erik-Handeland commented Apr 7, 2023 •

edited

Loading