Add plugin: Todoist Indicator

[kapej42]

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/kapej42/obsidian-todoist-indicator

Release Checklist

• I have tested the plugin on
  • Windows
  • macOS
  • Linux
  • Android (if applicable)
  • iOS (if applicable)
• My GitHub release contains all required files
  • main.js
  • manifest.json
  • styles.css (optional)
• GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
• The id in my manifest.json matches the id in the community-plugins.json file.
• My README.md describes the plugin's purpose and provides clear usage instructions.
• I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
• I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
• I have added a license in the LICENSE file.
• My project respects and is compatible with the original license of any code from other plugins that I'm using.
  I have given proper attribution to these other projects in my README.md.

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ Plugin name mismatch, the name in this PR (Todoist indicator) is not the same as the one in your repo (Todoist Indicator). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[ObsidianReviewBot]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Please remove the main.js file from the repo and add it to your .gitignore. Compiled release files shouldn't get mixed with source code in your commits and should go to the releases files instead.

---

Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

[ObsidianReviewBot]

Changes requested by bot have been made, assigning human for additional review.

[joethei]

The data.json file should not be part of the repo, remove it and add it to the .gitignore

"description": "Adds a badge to "project" files when they miss a link to a Todoist project. (based on the GTD indicator from saibotsivad.",
Missing closing bracket.

Use the parseYaml function from the Obsidian API instead of reinventing the wheel.

const fileFound = files.find(file => file.path === filepath)
[Avoid iterating all files to find a file by its path]https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Avoid+iterating+all+files+to+find+a+file+by+its+path

function containsTag(file, tag) {
Use the following code instead:

const tags = getAllTags(app.metadataCache.getFileCache(file));
return tags.includes(tag);

containerEl.createEl('h2', { text: 'Todoist Indicator plugin Settings' });
Don't add a top-level heading in the settings tab, such as "General", "Settings", or the name of your plugin.

containerEl.createEl('p', { text: 'Please reload Obsidian after changeing these sesttings for them to take effect.' });
Multiple typos.

.setName('Require Project Tag?')
Use sentence case in UI

[joethei]

Repeating the review issues again since the line numbers changed.

The data.json file should not be part of the repo, remove it and add it to the .gitignore

function getFrontMatter(markdownString: string) {
To read the frontmatter for a note use this.app.metadataCache.getFileCache(file)?.frontmatter and remove this code.

const fileFound = files.find(file => file.path === filepath);
Avoid iterating all files to find a file by its path

function containsTag(file: any, tag: string) {
Use the following code instead:

const tags = getAllTags(app.metadataCache.getFileCache(file));
return tags.includes(tag);

class SampleModal extends Modal {
Remove this sample code.

containerEl.createEl('h2', { text: 'Todoist Indicator plugin Settings' });

Don't add a top-level heading in the settings tab, such as "General", "Settings", or the name of your plugin.

.setName('Require Project Tag?')
Use sentence case in UI

[kapej42]

Thanks for your feedback. I've taken the opportunity to use the plugin template from Obsidian as a base and at the same time implemented your suggestions, good points.