Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hash equality #22

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Fix hash equality #22

merged 1 commit into from
Aug 11, 2020

Conversation

tomsmalley
Copy link
Collaborator

@tomsmalley tomsmalley commented Aug 11, 2020 •
edited
Loading

Alternate title: JavaScript strikes again

@3noch
Copy link
Collaborator

3noch commented Aug 11, 2020

Oh my goodness. That's reference equality isn't it.... 😭

@3noch 3noch merged commit b334d9e into ava Aug 11, 2020
@3noch
Copy link
Collaborator

3noch commented Aug 11, 2020

It utterly baffles me that the default behavior for == is reference equality. That should be like some deeply buried feature...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3noch 3noch 3noch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomsmalley @3noch