Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIMD Everywhere #255

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Add SIMD Everywhere #255

merged 2 commits into from
Jul 30, 2024

Conversation

tytan652
Copy link
Contributor

@tytan652 tytan652 commented Jul 9, 2024

Description

Add SIMD Everywhere to obs-deps

Motivation and Context

Reduce in-tree vendored deps in OBS Studio repo.

How Has This Been Tested?

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted one minor issue.

deps.windows/60-simde.ps1 Outdated Show resolved Hide resolved
@RytoEX RytoEX requested a review from PatTheMav July 25, 2024 21:02
Copy link
Member

@PatTheMav PatTheMav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note that this will cause a divergence in SIMDe header versions between Windows, macOS and the various Linux distros, as the latter are subject to whatever packages they have available. I suppose if packagers need a specific version, they can patch in whatever they need.

@RytoEX RytoEX merged commit c7108ce into obsproject:master Jul 30, 2024
21 checks passed
@tytan652 tytan652 deleted the simde branch July 30, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants