Skip to content

Commit

Permalink
UI: Set automatic file splitting time in minutes
Browse files Browse the repository at this point in the history
The original PR was made with time specified in seconds because it was
useful to debug the behavior. For production, assuming most users want
to specify 10 minutes or more, the time should be specified in minutes.
  • Loading branch information
norihiro authored and jp9000 committed Apr 11, 2022
1 parent b745a10 commit ebc2919
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions UI/forms/OBSBasicSettings.ui
Original file line number Diff line number Diff line change
Expand Up @@ -2461,16 +2461,16 @@
<item row="8" column="1">
<widget class="QSpinBox" name="advOutSplitFileTime">
<property name="suffix">
<string> s</string>
<string> min</string>
</property>
<property name="minimum">
<number>5</number>
<number>1</number>
</property>
<property name="maximum">
<number>21600</number>
<number>360</number>
</property>
<property name="value">
<number>900</number>
<number>15</number>
</property>
</widget>
</item>
Expand Down
2 changes: 1 addition & 1 deletion UI/window-basic-main-outputs.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1910,7 +1910,7 @@ bool AdvancedOutput::StartRecording()
obs_data_set_bool(settings, "allow_overwrite",
overwriteIfExists);
obs_data_set_int(settings, "max_time_sec",
splitFileTime);
splitFileTime * 60);
obs_data_set_int(settings, "max_size_mb",
splitFileSize);
obs_data_set_bool(settings, "reset_timestamps",
Expand Down
2 changes: 1 addition & 1 deletion UI/window-basic-main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1424,7 +1424,7 @@ bool OBSBasic::InitBasicConfigDefaults()
config_set_default_uint(basicConfig, "AdvOut", "Track5Bitrate", 160);
config_set_default_uint(basicConfig, "AdvOut", "Track6Bitrate", 160);

config_set_default_uint(basicConfig, "AdvOut", "RecSplitFileTime", 900);
config_set_default_uint(basicConfig, "AdvOut", "RecSplitFileTime", 15);
config_set_default_uint(basicConfig, "AdvOut", "RecSplitFileSize",
2048);
config_set_default_bool(basicConfig, "AdvOut",
Expand Down

0 comments on commit ebc2919

Please sign in to comment.