Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing -fPIC #3436

Closed
yurivict opened this issue Sep 8, 2020 · 9 comments
Closed

Missing -fPIC #3436

yurivict opened this issue Sep 8, 2020 · 9 comments

Comments

@yurivict
Copy link

yurivict commented Sep 8, 2020 •
edited

Build fails on some FreeBSD systems:

ld: error: relocation R_386_PC32 cannot be used against symbol strlist_split; recompile with -fPIC

Log: http://beefy5.nyi.freebsd.org/data/121i386-default/547958/logs/obs-studio-26.0.0.r1.log

Platform

Operating system and version: FreeBSD 12.1 i386
OBS Studio version: 26.0.0-rc1

Likely the issue is only present on i386 architectures.

Expected Behavior

Build succeeds.

Current Behavior

Build breaks.

Steps to Reproduce

Build the package: cmake . && gmake

Additional information

none
@Fenrirthviti
Copy link
Member

Please properly fill out the issue template.

@Gol-D-Ace
Copy link
Member

This is also also happening on Ubuntu 16.04 aka Xenial. Probably happening because of an too old x264 version that didn't include this.

Compilation on newer Ubuntu versions with newer x264 Versions does work fine..

@Gol-D-Ace
Copy link
Member

Just checked and it might not be necessary age.
Bionic for example is using 2:0.152.2854+gite9a5903-2 which is older than the version in your log

@yurivict
Copy link
Author

yurivict commented Sep 8, 2020 •
edited

FreeBSD uses x264 revision cde9a933 (160.3011) from 2 months ago (https://code.videolan.org/videolan/x264/-/commits/master).

@notr1ch
Copy link
Member

notr1ch commented Sep 8, 2020

This is unrelated to libx264 as it's the libobs x264 option parsing code that is the issue. For some reason libobs-x264-util is being built without -fPIC like all other modules.

@notr1ch
Copy link
Member

notr1ch commented Sep 8, 2020

Please try this patch: notr1ch@479f80c

@yurivict
Copy link
Author

yurivict commented Sep 8, 2020

This would be quite difficult and long for me to test, because failing systems are only on the farm.

Could you please just check that all commands have -fPIC in them, this should be sufficient.

@notr1ch
Copy link
Member

notr1ch commented Sep 8, 2020

OBS does not set CFLAGS directly, they are generated by CMake. I have updated the CMakefiles to include the option for PIC, which I presume will now set CFLAGS to contain -fPIC, however I also have no system on which to test this.

@yurivict
Copy link
Author

yurivict commented Sep 8, 2020

When you run 'make VERBOSE=1' it print all command lines. You can just compare before and after logs.

@notr1ch notr1ch closed this as completed in 5889e29 Sep 8, 2020
@notr1ch notr1ch mentioned this issue Sep 19, 2020
Closed
Oncorporation pushed a commit to Oncorporation/obs-studio that referenced this issue Oct 26, 2020
@notr1ch @Oncorporation
CMake: Set PIC for all library targets
f8abae3 
Fixes obsproject#3436
1div0 pushed a commit to 1div0/obs-studio that referenced this issue Apr 22, 2021
@notr1ch @1div0
CMake: Set PIC for all library targets
c10e619 
Fixes obsproject#3436
joelvaneenwyk added a commit to joelvaneenwyk/obs-studio that referenced this issue Aug 29, 2023
@joelvaneenwyk
CMake: Set PIC for all library targets which fixes codespace build is…
56ed584 
…sues as in <obsproject#3436> where this was cherry-picked from.
joelvaneenwyk added a commit to joelvaneenwyk/obs-stream-fx that referenced this issue Sep 22, 2023
@joelvaneenwyk
Squashed 'third-party/obs-studio/' changes from 4b2d306ae..ae40a2a92
445e738 
ae40a2a92 Cleaned up batch script to log output for install
21061b847 chore: Batch script cleanup
6be0bfe16 Initial pass at improving setup scripts
824f89a41 Improved OBS Studio launch script
18267de95 Improvements to startup script and always start virtual cam and minimize to tray
849e92388 chore: Reformat GitHub actions
53d0c9caf chore: Cleanup build script
6af83ca54 chore: Fixed VSCode CMake settings to work directly on Windows
c909af874 Updated format checking scripts (#1)
d6b986672 Update GitHub actions and remove unsupported variants
c84ea4a98 Minor clang-format changes when using v18.0
726ff34b0 Add/update helper scripts for building and running on Windows
26d576795 Remove CMake intermediate files
d2df0d5a2 Config updates for CLion and VSCode
6871373d7 chore: VSCode config updates
39e56120f Update streamfx submodule to point at latest
24192e6b0 Fixed bugs in CMake due to recent cherry pick
df6dfeb11 chore: Config updates
dc11c596c Fix bad merge.
56ed5846e CMake: Set PIC for all library targets which fixes codespace build issues as in <obsproject/obs-studio#3436> where this was cherry-picked from.
40c8e2f95 chore: Tweaks/updates to configs

git-subtree-dir: third-party/obs-studio
git-subtree-split: ae40a2a92e02652b7d848f12f11b8887900cd9c3
sorenisanerd pushed a commit to sorenisanerd/obs-studio that referenced this issue Jan 20, 2024
@notr1ch @sorenisanerd
CMake: Set PIC for all library targets
bbabbba 
Fixes obsproject#3436
joelvaneenwyk added a commit to joelvaneenwyk/obs-studio that referenced this issue Jan 23, 2024
@joelvaneenwyk
Add 'streamfx' module. First commit as part of squashed commit.
b816661 
commit 2ce732c
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Sun Jan 21 12:00:53 2024 -0800

    Add editor settings

commit 831136b
Author: joelvaneenwyk <joel.vaneenwyk@gmail.com>
Date:   Thu Oct 26 14:42:21 2023 -0700

    chore: Minor build script cleanup

commit aca7d56
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Wed Sep 27 14:51:48 2023 -0700

    Consolidated launch and build scripts

commit 1eaf7c8
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Tue Sep 26 20:03:45 2023 -0700

    Updated submodules

commit f401439
Author: joelvaneenwyk <joel.vaneenwyk@gmail.com>
Date:   Tue Sep 26 15:19:44 2023 -0700

    Updated StreamFX branch to latest

commit f7b27a8
Author: joelvaneenwyk <joel.vaneenwyk@gmail.com>
Date:   Tue Sep 26 15:11:49 2023 -0700

    Add links to NVIDIA sdks in README

commit 4943528
Author: joelvaneenwyk <joel.vaneenwyk@gmail.com>
Date:   Tue Sep 26 15:08:03 2023 -0700

    Add 'clean' as optional argument to build script

commit 3e002b2
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Tue Sep 26 14:11:42 2023 -0700

    Fix launch script and add uninstall script for virtual camera

commit ae40a2a
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Thu Sep 21 17:25:57 2023 -0700

    Cleaned up batch script to log output for install

commit 21061b8
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Thu Sep 21 17:15:08 2023 -0700

    chore: Batch script cleanup

commit 6be0bfe
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Thu Sep 21 16:53:40 2023 -0700

    Initial pass at improving setup scripts

commit 824f89a
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Thu Sep 21 09:52:31 2023 -0700

    Improved OBS Studio launch script

commit 18267de
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Wed Sep 20 17:19:56 2023 -0700

    Improvements to startup script and always start virtual cam and minimize to tray

commit 849e923
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Tue Sep 5 15:37:56 2023 -0700

    chore: Reformat GitHub actions

commit 53d0c9c
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Sep 4 15:55:50 2023 -0700

    chore: Cleanup build script

commit 6af83ca
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Sep 4 15:45:11 2023 -0700

    chore: Fixed VSCode CMake settings to work directly on Windows

commit c909af8
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Sep 4 14:09:35 2023 -0700

    Updated format checking scripts (#1)

    * Added LLVM script to install clang-format-13
    * Re-run clang format with v13.0
    * Fix cmake-format
    * Update GitHub actions and remove unsupported variants
    * Apply StreamFX patches
    * Update path to `buildspec.js`

commit d6b9866
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Sep 4 12:47:59 2023 -0700

    Update GitHub actions and remove unsupported variants

commit c84ea4a
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Sep 4 14:08:35 2023 -0400

    Minor clang-format changes when using v18.0

commit 726ff34
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Wed Aug 30 13:12:12 2023 -0700

    Add/update helper scripts for building and running on Windows

commit 26d5767
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Wed Aug 30 13:11:34 2023 -0700

    Remove CMake intermediate files

commit d2df0d5
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Wed Aug 30 10:00:21 2023 -0700

    Config updates for CLion and VSCode

commit 6871373
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Wed Aug 30 09:28:43 2023 -0700

    chore: VSCode config updates

commit 39e5612
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Tue Aug 29 15:15:41 2023 -0700

    Update streamfx submodule to point at latest

commit 24192e6
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Tue Aug 29 13:17:15 2023 -0700

    Fixed bugs in CMake due to recent cherry pick

commit df6dfeb
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Tue Aug 29 11:47:15 2023 -0400

    chore: Config updates

commit dc11c59
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Aug 28 23:43:26 2023 -0400

    Fix bad merge.

commit 56ed584
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Aug 28 23:39:16 2023 -0400

    CMake: Set PIC for all library targets which fixes codespace build issues as in <obsproject#3436> where this was cherry-picked from.

commit 40c8e2f
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Aug 28 23:39:01 2023 -0400

    chore: Tweaks/updates to configs

commit 4b2d306
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Aug 28 12:59:20 2023 -0700

    Update GitHub actions to use 'main' branch

commit 0e89173
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Aug 28 12:46:13 2023 -0700

    Update streamfx submodule plugin to latest

commit 17e8097
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Aug 28 10:33:23 2023 -0700

    Add streamfx plugin
joelvaneenwyk added a commit to joelvaneenwyk/obs-studio that referenced this issue Jan 23, 2024
@joelvaneenwyk
Add 'streamfx' module. First commit as part of squashed commit.
57ec0db 
commit 2ce732c
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Sun Jan 21 12:00:53 2024 -0800

    Add editor settings

commit 831136b
Author: joelvaneenwyk <joel.vaneenwyk@gmail.com>
Date:   Thu Oct 26 14:42:21 2023 -0700

    chore: Minor build script cleanup

commit aca7d56
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Wed Sep 27 14:51:48 2023 -0700

    Consolidated launch and build scripts

commit 1eaf7c8
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Tue Sep 26 20:03:45 2023 -0700

    Updated submodules

commit f401439
Author: joelvaneenwyk <joel.vaneenwyk@gmail.com>
Date:   Tue Sep 26 15:19:44 2023 -0700

    Updated StreamFX branch to latest

commit f7b27a8
Author: joelvaneenwyk <joel.vaneenwyk@gmail.com>
Date:   Tue Sep 26 15:11:49 2023 -0700

    Add links to NVIDIA sdks in README

commit 4943528
Author: joelvaneenwyk <joel.vaneenwyk@gmail.com>
Date:   Tue Sep 26 15:08:03 2023 -0700

    Add 'clean' as optional argument to build script

commit 3e002b2
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Tue Sep 26 14:11:42 2023 -0700

    Fix launch script and add uninstall script for virtual camera

commit ae40a2a
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Thu Sep 21 17:25:57 2023 -0700

    Cleaned up batch script to log output for install

commit 21061b8
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Thu Sep 21 17:15:08 2023 -0700

    chore: Batch script cleanup

commit 6be0bfe
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Thu Sep 21 16:53:40 2023 -0700

    Initial pass at improving setup scripts

commit 824f89a
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Thu Sep 21 09:52:31 2023 -0700

    Improved OBS Studio launch script

commit 18267de
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Wed Sep 20 17:19:56 2023 -0700

    Improvements to startup script and always start virtual cam and minimize to tray

commit 849e923
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Tue Sep 5 15:37:56 2023 -0700

    chore: Reformat GitHub actions

commit 53d0c9c
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Sep 4 15:55:50 2023 -0700

    chore: Cleanup build script

commit 6af83ca
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Sep 4 15:45:11 2023 -0700

    chore: Fixed VSCode CMake settings to work directly on Windows

commit c909af8
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Sep 4 14:09:35 2023 -0700

    Updated format checking scripts (#1)

    * Added LLVM script to install clang-format-13
    * Re-run clang format with v13.0
    * Fix cmake-format
    * Update GitHub actions and remove unsupported variants
    * Apply StreamFX patches
    * Update path to `buildspec.js`

commit d6b9866
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Sep 4 12:47:59 2023 -0700

    Update GitHub actions and remove unsupported variants

commit c84ea4a
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Sep 4 14:08:35 2023 -0400

    Minor clang-format changes when using v18.0

commit 726ff34
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Wed Aug 30 13:12:12 2023 -0700

    Add/update helper scripts for building and running on Windows

commit 26d5767
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Wed Aug 30 13:11:34 2023 -0700

    Remove CMake intermediate files

commit d2df0d5
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Wed Aug 30 10:00:21 2023 -0700

    Config updates for CLion and VSCode

commit 6871373
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Wed Aug 30 09:28:43 2023 -0700

    chore: VSCode config updates

commit 39e5612
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Tue Aug 29 15:15:41 2023 -0700

    Update streamfx submodule to point at latest

commit 24192e6
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Tue Aug 29 13:17:15 2023 -0700

    Fixed bugs in CMake due to recent cherry pick

commit df6dfeb
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Tue Aug 29 11:47:15 2023 -0400

    chore: Config updates

commit dc11c59
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Aug 28 23:43:26 2023 -0400

    Fix bad merge.

commit 56ed584
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Aug 28 23:39:16 2023 -0400

    CMake: Set PIC for all library targets which fixes codespace build issues as in <obsproject#3436> where this was cherry-picked from.

commit 40c8e2f
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Aug 28 23:39:01 2023 -0400

    chore: Tweaks/updates to configs

commit 4b2d306
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Aug 28 12:59:20 2023 -0700

    Update GitHub actions to use 'main' branch

commit 0e89173
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Aug 28 12:46:13 2023 -0700

    Update streamfx submodule plugin to latest

commit 17e8097
Author: Joel Van Eenwyk <joel.vaneenwyk@gmail.com>
Date:   Mon Aug 28 10:33:23 2023 -0700

    Add streamfx plugin

# Conflicts:
#	.gitmodules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yurivict @notr1ch @Gol-D-Ace @Fenrirthviti