Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtmp-services: Update Switchboard Live servers #10021

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

sarwin-github
Copy link

@sarwin-github sarwin-github commented Dec 19, 2023

Description

The Switchboard Live Server URLs have been recently updated in the application, so the URLs need to be updated in OBS to match.

Motivation and Context

There were recent changes to the ingestion servers at Switchboard Live. We also removed Legacy url.

How Has This Been Tested?

  • This was tested using the latest build of OBS on Windows.
  • Testing consisted of going live with every server to ensure connectivity was stable.

Types of changes

  • Tweak (non-breaking change to improve existing functionality).
  • Removed Alt names

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@gxalpha gxalpha added the Services These are modifications to the Service list and are not tied to the release schedule label Dec 19, 2023
Copy link
Member

@gxalpha gxalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit history is getting ugly, try to only have one commit containing the change, without any merge commits. This is why it's recommended to not use the master branch for PRs.
See the comment below.

plugins/rtmp-services/data/services.json Outdated Show resolved Hide resolved
@Fenrirthviti
Copy link
Member

Commits still need to be squashed before this can be merged.

@RytoEX RytoEX self-assigned this Feb 29, 2024
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the issues with this PR manually because the legacy ingest is gone and is causing CI failures when we try to run our services tests.

In the future:

  1. Do not submit a PR from your fork's master branch.
  2. Do not use merge commits to keep your branch up to date. Use git rebase instead.
  3. Do not change or remove existing entries in the alt_names key. You can only add new entries. This is used so that existing user setups with the old names do not break.

If you do not follow this advice, your future PRs may be closed.

@RytoEX RytoEX added this to the OBS Studio 30.1 milestone Mar 7, 2024
@RytoEX RytoEX merged commit 71660dc into obsproject:master Mar 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Services These are modifications to the Service list and are not tied to the release schedule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants