Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Use normal source width for screenshots #10077

Merged
merged 1 commit into from Jan 7, 2024

Conversation

gxalpha
Copy link
Member

@gxalpha gxalpha commented Jan 4, 2024

Description

Fixes an issue where filters that resize a source, like "Crop/Pad" or "Scaling/Aspect Ratio", change the texture but the new source size gets ignored, effectively either cropping the screenshot or giving it black borders.

Motivation and Context

Fixes #9956

How Has This Been Tested?

macOS 14.2
Took a screenshot of a source that had a Crop/Pad filter applied and confirmed that the black border has gone away.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Fixes an issue where filters that resize a source, like "Crop/Pad" or
"Scaling/Aspect Ratio", change the texture but the new source size gets
ignored, effectively either cropping the screenshot or giving it black
borders.
@gxalpha gxalpha added the Bug Fix Non-breaking change which fixes an issue label Jan 4, 2024
@Lain-B Lain-B merged commit 089fa8e into obsproject:master Jan 7, 2024
14 checks passed
@gxalpha gxalpha deleted the screenshot-normal-source-width branch January 7, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Screenshot (Source)" doesn't account for the "Scaling/Aspect Ratio" filter.
2 participants