Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-aux: Update Flatpak SVT-AV1 module to 2.0 #10405

Closed
wants to merge 1 commit into from

Conversation

deadmeu
Copy link
Contributor

@deadmeu deadmeu commented Mar 19, 2024

Description

Updates the SVT-AV1 encoder included in the Flatpak modules list to the recently released 2.0 version.

Motivation and Context

The new version of the encoder is more performant and would be nice to have available in OBS.

How Has This Been Tested?

Lightly tested by:

  1. I ran flatpak-builder builddir --force-clean build-aux/com.obsproject.Studio.json --user --install.
  2. After the build completed successfully, I opened OBS and verified the "SVT-AV1" Video Encoder was available.
  3. I closed OBS and ran flatpak run --command=bash com.obsproject.Studio.
  4. In the new session I ran ffmpeg -i example-file.mp4 -c:a copy -c:v libsvtav1 out.mp4.
  5. I checked ffmpeg's output and verified the reported SVT [version] was listed as SVT-AV1 Encoder Lib v2.0.0.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)
  • Performance enhancement (non-breaking change which improves efficiency)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX
Copy link
Member

RytoEX commented Mar 19, 2024

We tend to update dependencies ourselves and in sync with when we update all platforms together. As such, I'm not inclined to merge this separately, and I might close this.

@RytoEX RytoEX self-assigned this Mar 23, 2024
@RytoEX
Copy link
Member

RytoEX commented Mar 27, 2024

As mentioned, I'm going to close this. We handle our own deps updates rather intentionally, and we'll get to this when we next look to update our dependencies, provided that our testing shows no issues.

@RytoEX RytoEX closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants