UI: Fix Auto-Config Wizard for custom server with no stream key

[mar10iana]

Description

The issue reported on GitHub involves the OBS Studio Auto-Configuration Wizard becoming non-functional when a custom server is selected without requiring a stream key, preventing further progress. To address this, I included the !custom constraint in the if condition within the UpdateCompleted() function, aiming to handle cases where a custom server is used without a stream key, thereby allowing the wizard to proceed as expected.

Motivation and Context

This change improves the user experience in OBS Studio, especially for those utilizing custom streaming services. It solves the problem outlined in this issue: obsproject/obs-studio#10087, where the setup wizard would inaccurately report readiness due to not considering custom services without a provided stream key.

Fixes #10087

How Has This Been Tested?

This has been tested using a macOS environment.

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code has been run through clang-format.
• I have read the contributing document.
• My code is not on the master branch.
• The code has been tested.
• All commit messages are properly formatted and commits squashed where appropriate.
• I have included updates to all appropriate documentation.

[RytoEX]

Please omit the Issue number from the commit message. Please also update the PR title to use the commit message subject.

Please wrap the commit message body at 72 characters, as described in our Commit Guidelines.

In the future, we recommend not submitting patches from your master branch, because submitting from your master branch tends to introduce extra challenges.

Please actually fill out the full PR template. Please also indicate what testing you have done on this code.

[mar10iana]

Thank you! I will make those changes now

[mar10iana]

I've updated the PR template and commit message. Please excuse any oversights, as this is my first contribution. If there's anything else that needs adjustment or inclusion, I'll address it as soon as possible. Thank you!

[RytoEX]

This does seem to fix the issue as described.

Commit message nit:

• Use a verb as the first word after the prefix

I have provided a commit message that addresses that nit and clarifies the reason for the change:

UI: Fix Auto-Config Wizard for custom server with no stream key

The Auto-Configuration Wizard cannot progress when selecting a custom
service that does not require a stream key. Since we have no way to
validate if a custom service requires a stream key, we should just not
require a stream key is custom service is selected. To fix this, check
if a custom service has not been selected when checking if the stream key
is empty.

[mar10iana]

Thank you! I have update the commit and the title of the PR

[norihiro]

In the commit message, the line
if a custom service has not been selected when checking if the stream key
contains 73 characters. Please fold between stream and key.

[RytoEX]

In the commit message, the line if a custom service has not been selected when checking if the stream key contains 73 characters. Please fold between stream and key.

That appears to be my fault. Probably checked my own work too quickly.