text-freetype2: Fix bug with null characters

[lourencop01]

When uploading a file containing null characters only the characters before the first null character would be rendered. Fixed by sanitizing the null characters from the bytes read from the uploaded file.

Description

Sanitize null characters from the bytes read from an uploaded file.

Motivation and Context

This change fixes the issue reported on: obs-studio/issues#7595, where when a user uploaded a file containing null characters, only the characters prior to the first null character would be rendered. With this fix, the correct text from the file is rendered.

How Has This Been Tested?

The changes were tested by uploading a file containing null characters.
The testing environment is macOS Sonoma 14.3.1

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code has been run through clang-format.
• I have read the contributing document.
• My code is not on the master branch.
• The code has been tested.
• All commit messages are properly formatted and commits squashed where appropriate.
• I have included updates to all appropriate documentation.

[kkartaltepe]

This seems like it would work, but I'm not sure we are keen on committing a workaround for this issue other than just fixing string handling throughout.

[lourencop01]

Got it, no worries!

Since you're not looking for either displaying null characters as glyphs or sanitizing them, could you please clarify what the ideal solution would be?

Thank you!

[lourencop01]

Hey, just following up on this last message to bump it up on your notifications box! :)

[kkartaltepe]

#7595 (comment) covers this. Specifically we dont need to change null bytes or use any special representation of them to fix the issue, just to manage the length of strings correctly.