Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: When no source is selected, the text indicating this appears cut off in some languages #10456

Closed
wants to merge 1 commit into from

Conversation

Diog0o
Copy link

@Diog0o Diog0o commented Mar 29, 2024

Description

In some languages as Portuguese (PT), Portuguese-Brasil (PT-BR) and Spanish (ES) the last few words dind't appear because they were cut off. The solution was to increase the maximumSize width of the "contextSourceLabel" from 160 to 200. I tested in every single language and it's working fine.

Motivation and Context

This change fixes the issue reported on: #7360, where when so source was selected, the text suggesting that appeared cut off in some languages including: Portuguese and Spanish.

How Has This Been Tested?

The testing environment was Windows 11, replicating the observed behavior in all languages.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Diog0o Diog0o changed the title UI: When no source is selected, the text indicating this appears cut off in some languages #7360 UI: When no source is selected, the text indicating this appears cut off in some languages Mar 29, 2024
@RytoEX RytoEX requested a review from Warchamp7 March 29, 2024 15:27
@WizardCM WizardCM added Bug Fix Non-breaking change which fixes an issue UI/UX Anything to do with changes or additions to UI/UX elements. labels Mar 30, 2024
@norihiro
Copy link
Contributor

The commit message should be wrapped to 72 columns.

In some languages as Portuguese (PT), Portuguese-Brasil (PT-BR) and Spanish
(ES) the last few words dind't appear. The solution was to increase de width
from 160 to 200. I tested in every single language and it's working fine.

Resolves: #7360
@Diog0o
Copy link
Author

Diog0o commented Mar 31, 2024

The commit message should be wrapped to 72 columns.

Done!

@Warchamp7
Copy link
Member

We're going to discuss alternative ways to fix this, but this isn't the approach we'd like to take at this time.

@Warchamp7 Warchamp7 closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants