Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Generate/Verify Attestation for Windows builds #10706

Merged
merged 3 commits into from
May 28, 2024

Conversation

derrod
Copy link
Member

@derrod derrod commented May 22, 2024

Description

Adds GitHub's new attestation feature to Windows release workflows.

Motivation and Context

This ensures that the artifact used to generate delta updates has been generated on CI and has not been altered before the patch workflow runs.

How Has This Been Tested?

Tested on my fork.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@derrod derrod added the CI label May 22, 2024
@RytoEX RytoEX self-assigned this May 22, 2024
@derrod derrod force-pushed the ci-attestation branch 2 times, most recently from ea6eb01 to 33f2b51 Compare May 23, 2024 05:59
@derrod
Copy link
Member Author

derrod commented May 23, 2024

I've now tested this and verified it works as intended. Just needed the update to the commit hash as well.

@derrod derrod marked this pull request as ready for review May 23, 2024 05:59
@derrod derrod requested a review from RytoEX May 23, 2024 05:59
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay at a glance. @PatTheMav ?

@derrod I guess this requires a merge commit to avoid breaking the specified action hash?

@derrod
Copy link
Member Author

derrod commented May 24, 2024

@derrod I guess this requires a merge commit to avoid breaking the specified action hash?

Yes.

@RytoEX RytoEX merged commit 8c48f8c into obsproject:master May 28, 2024
15 checks passed
@derrod derrod deleted the ci-attestation branch May 28, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants