Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Only cache multitrack config URL startup argument #10887

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

palana
Copy link
Contributor

@palana palana commented Jun 19, 2024

Description

Allow usage of different multitrack config URLs between different stream attempts without restarting the program

Motivation and Context

This is an artifact from when development on multitrack video started, before services could supply their config URLs through services.json

This currently works when switching between Twitch and Amazon IVS due to some infrastructure being shared, but won't work if switching between Twitch/Amazon IVS and a completely different service

How Has This Been Tested?

Switched between Twitch and Amazon IVS and verified that they use their own service URLs:

13:27:18.508: Go live URL: https://ingest.contribute.live-video.net/api/v3/GetClientConfiguration
[…]
13:27:38.260: Go live URL: https://ingest.twitch.tv/api/v3/GetClientConfiguration

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Copy link
Member

@derrod derrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to explicitly call .has_value() in an if expression but it's fine.

@WizardCM WizardCM added the Bug Fix Non-breaking change which fixes an issue label Jun 19, 2024
@RytoEX RytoEX added this to the OBS Studio 30.2 milestone Jun 19, 2024
@RytoEX RytoEX self-assigned this Jun 19, 2024
@RytoEX RytoEX merged commit 8a8019d into obsproject:master Jun 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants