Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-ffmpeg: Close VAAPI device on vaInitialize fail (memory leak fix) #10897

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

tt2468
Copy link
Member

@tt2468 tt2468 commented Jun 20, 2024

Description

On some systems (eg. mine), VAAPI fails on vaInitialize. Valgrind was able to spot that the device was not being closed, and it appears to have been correct. This fixes a memory leak.

Motivation and Context

Using NVIDIA GPUs on Ubuntu 22.04 shouldn't cause memory leaks, even if small.

How Has This Been Tested?

Tested on Ubuntu 22.04 that valgrind does not complain about this function when patched.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

On some systems (eg. mine), VAAPI fails on vaInitialize. Valgrind was
able to spot that the device was not being closed, and it appears to
have been correct. This fixes a memory leak.
@tt2468 tt2468 added Bug Fix Non-breaking change which fixes an issue Linux Affects Linux labels Jun 20, 2024
@tt2468 tt2468 merged commit 6c38927 into obsproject:master Jun 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Linux Affects Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants