Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win-wasapi: Remove noisy and useless debug logging #10898

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

derrod
Copy link
Member

@derrod derrod commented Jun 20, 2024

Description

Removes some leftover debug logging messages that have outlived their usefulness.

Motivation and Context

These were originally added to help troubleshoot the application audio capture issues. Since it has been established that those are a Windows bug we can't detect or work around, we don't need these any longer.

They also keep annoying me because I run OBS with verbose logging for testing and especially the silent flag gets quite spammy.

How Has This Been Tested?

N/A

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@derrod derrod added Code Cleanup Non-breaking change which makes code smaller or more readable Windows Affects Windows labels Jun 20, 2024
@Lain-B
Copy link
Collaborator

Lain-B commented Jul 6, 2024

Just going to merge this for 30.2 because it's trivial and it just cleans up the debug output. I'd rather have unnecessary noise even if it is in verbose logging. Additionally I don't think these logging message have ever proven be actually be useful in any way/shape/form.

@Lain-B Lain-B merged commit 877ddad into obsproject:master Jul 6, 2024
15 checks passed
@RytoEX RytoEX added this to the OBS Studio 30.2 milestone Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Non-breaking change which makes code smaller or more readable Windows Affects Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants