linux-pipewire: Remove extra loop teardown #10899
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pw_thread_loop_wait must be called with the lock held, so this code was throwing warnings on newer pipewire libraries. With it removed there seems to be no reason to perform a stop before destroying the loop which will internally call stop since at least 7 years ago.
https://gitlab.freedesktop.org/pipewire/pipewire/-/blame/d0a2e6316bb652b064db8f2ff63b86afd52bddfb/src/pipewire/thread-loop.c#L247
Motivation and Context
No more pipewire warnings on shutdown.
How Has This Been Tested?
Test scene shutsdown fine still.
Types of changes
Checklist: