Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-pipewire: Remove extra loop teardown #10899

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kkartaltepe
Copy link
Collaborator

Description

pw_thread_loop_wait must be called with the lock held, so this code was throwing warnings on newer pipewire libraries. With it removed there seems to be no reason to perform a stop before destroying the loop which will internally call stop since at least 7 years ago.

https://gitlab.freedesktop.org/pipewire/pipewire/-/blame/d0a2e6316bb652b064db8f2ff63b86afd52bddfb/src/pipewire/thread-loop.c#L247

Motivation and Context

No more pipewire warnings on shutdown.

How Has This Been Tested?

Test scene shutsdown fine still.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

pw_thread_loop_wait must be called with the lock held, so this code was
throwing warnings on newer pipewire libraries. With it removed there
seems to be no reason to perform a stop before destroying the loop which
will internally call stop since at least 7 years ago.
@WizardCM WizardCM added the Code Cleanup Non-breaking change which makes code smaller or more readable label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Non-breaking change which makes code smaller or more readable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants