Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win-capture: Capture animated cursors #1299

Closed
wants to merge 3 commits into from

Conversation

SuslikV
Copy link
Contributor

@SuslikV SuslikV commented May 16, 2018

Add ability to capture/draw animated Windows cursors (mouse pointers).
Fixes issue when animated cursor was captured as static image by
Window Capture source.

Fixes: https://obsproject.com/mantis/view.php?id=1233

Load undocumented WINAPI function GetCursorFrameInfo() to support
animated cursors draw.
Add ability to capture/draw animated Windows cursors (mouse pointers).
Fixes issue when animated cursor was captured as static image by
Window Capture source.
Add new option to Window Capture properties to control over animation
in the captured mouse pointer.
@SuslikV
Copy link
Contributor Author

SuslikV commented May 16, 2018

Animation in the mouse pointer for Display Capture source (at least under the win10) is out of scope by this PR.

@SuslikV
Copy link
Contributor Author

SuslikV commented Jun 11, 2018

I should mention, that this feature was never asked (I didn't found any related requests but mine) on the obs forum or anywhere else.

@jp9000 jp9000 added the Review delayed Full review has been delayed due to time constraints of the maintainer label Jul 18, 2018
@jp9000
Copy link
Member

jp9000 commented Jul 18, 2018

Do you have an example where this is something that you'd sort of deem as necessary or important to have? Just out of curiosity. The solution feels so complex to solve -- is it really worth it?

@SuslikV
Copy link
Contributor Author

SuslikV commented Jul 21, 2018

Actually, I was looking into how cursor capture works in obs (in attempt to resolve the crash issue that time to time may happen in OBS Studio - https://obsproject.com/mantis/view.php?id=996) and thus, I made attempt to reproduce the issue. During this attempts I noticed that cursors scaled wrongly, I tried to fix it (#1284). But still unable to reproduce the issue, then I noticed, that animated cursors not captured, I tried to fix it... Now I see, that there was optimization in textures caching by texture size.

So, it is more like theoretical feature. It deviates from the main goal I had, but nobody do it, as I see. It is optional, by the way.

As for further improvements (shadow, trail, locator etc.) - I think, who doing 1:1 capture, can use the capture card.

One more thing, while working with this code I found another issue: https://obsproject.com/mantis/view.php?id=1242
All this is small things, and I doubt that you'll see major fix from me to the OBS Studio in the future.

@SuslikV
Copy link
Contributor Author

SuslikV commented Aug 31, 2018

68 PRs on the list..! I should close it for some time. There is no sense to keep the features for so long in development. Let's prioritize simple fixes.

@SuslikV SuslikV closed this Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review delayed Full review has been delayed due to time constraints of the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants