Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtmp-services: Add DTube #1419

Merged
merged 1 commit into from
Aug 17, 2018
Merged

rtmp-services: Add DTube #1419

merged 1 commit into from
Aug 17, 2018

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Aug 10, 2018

@gluneau
Copy link
Contributor Author

gluneau commented Aug 15, 2018

@jp9000, is it good to go?

How do we get the "common": true, entry? Any particular criteria measured?

Thanks.

@Chiitoo
Copy link
Contributor

Chiitoo commented Aug 15, 2018

With regards to 'common', here are some thoughts on that (albeit from a while ago, I suspect not much, if anything, has changed): #577 (comment)

(If I'm mistaken, someone will hopefully chime in. :])

@derrod
Copy link
Member

derrod commented Aug 15, 2018

Please check the Contributing guidelines and/or previous changes to rtmp-services and adjust your commit message accordingly.

As has already been mentioned the common tag is pretty arbitrary and large overhauls of the entire output configuration UI are planned for the major updates following version 22. Seeing as your site has exactly zero live streams and viewers right now it certainly does not need to be marked as "common".

@gluneau gluneau changed the title Livestreaming now available on DTube rtmp-services: add DTube Aug 15, 2018
@RytoEX
Copy link
Member

RytoEX commented Aug 15, 2018

@gluneau
Hi! You still need to update the commit subject line to comply with this project's commit guidelines. Prefix the commit subject with the component being modified, use a properly capitalized present tense verb, and a short descriptive message (50 characters or less). This would suffice:

rtmp-services: Add DTube

You can update the commit subject line by amending the commit locally and then doing a force push to overwrite the commit already present here.

@gluneau gluneau changed the title rtmp-services: add DTube rtmp-services: Add DTube Aug 16, 2018
@jp9000 jp9000 merged commit e195650 into obsproject:master Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants