Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-ffmpeg: Change clear on media end wording for media source #1733

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

VodBox
Copy link
Member

@VodBox VodBox commented Mar 10, 2019

As per mantis issue 1403, the current wording for ClearOnMediaEnd is
ambiguous. Since it says "Hide source", some may believe it to mean the
scene item in the sources list will have it's visibility set to hidden.
This wording makes it clearer what the checkbox actually does.

As per mantis issue 1403, the current wording for ClearOnMediaEnd is
ambiguous. Since it says "Hide source", some may believe it to mean the
scene item in the sources list will have it's visibility set to hidden.
This wording makes it clearer what the checkbox actually does.
@ntoff
Copy link

ntoff commented Mar 11, 2019

"show nothing" might be even more confusing, if you tick it, what would it show? "something"? What is that something? If it does what I think it does, wouldn't changing the way it works, and rewording it as "Keep last frame visible when playback ends (for video sources)" make more sense?

@SuslikV
Copy link
Contributor

SuslikV commented Mar 11, 2019

Add Tip:
Makes source transparent when playback ends.
or name it like:
Make source transparent when playback ends

From user's perspective it just makes the source transparent and audio simply ends (the audio source of the media still listed in the mixer's pane).

@DDRBoxman DDRBoxman merged commit e001e2d into obsproject:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants