UI: Upgrade stream key link to button in Wizard

[JohannMG]

Description

Follow up to previous pull request #2145
The wizard has a stream link URL as well. Adding the URL button in the
wizard to match. Additionally, fixing a few errors in the UI layout
and spacing where items were not padded.

Before:

After:

Motivation and Context

Matches UI of previous changes and fixes a button layout issue.

How Has This Been Tested?

Yes.
MacOS 10.14.6
MacBook Pro

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code has been run through clang-format.
• I have read the contributing document.
• My code is not on the master branch.
• The code has been tested.
• All commit messages are properly formatted and commits squashed where appropriate.

[Fenrirthviti]

Could you also adjust the service selection text and box to line up left justified with the Please enter your stream information and Stream key text?

[JohannMG]

Let's circle back to the other layout issues in another diff? There's a lot of little issues in here and I didn't want to snowball tracking them all down in this diff.

…

On Tue, Dec 17, 2019 at 19:03 Joel Bethke ***@***.***> wrote: Could you also adjust the service selection text and box to line up left justified with the Please enter your stream information and Stream key text? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2256?email_source=notifications&email_token=AAMB7NE3C2QCJC24GZTP6BLQZGHG5A5CNFSM4J4DS4L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHEWDMQ#issuecomment-566845874>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMB7NCQZO2DCNLRKEUURO3QZGHG5ANCNFSM4J4DS4LQ> .

[energizerfellow]

I don't like how the stream key field is abbreviated with the buttons on the same horizontal plane. The stream key field should be long enough to visually show the entirety of the stream key with the Show and Get Stream Key buttons below the stream key text field.

[JohannMG]

Truncated stream key fields are standard (not just in this UI or app) because keys are pasted in nearly every scenario. Most stream keys are long enough that even moving this button down wouldn't show the entire key. You can also see the discussion in the PR referenced above on having the button in line or not and in line was decided on that surface as well. Possibly we change this later but this matches other apps right now.

…

On Tue, Dec 17, 2019 at 20:45 energizerfellow ***@***.***> wrote: I don't like how the stream key field is abbreviated with the buttons on the same horizontal plane. The streak key field should be long enough to visually show the entirety of the stream key with the Show and Get Stream Key buttons below the stream key text field. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2256?email_source=notifications&email_token=AAMB7NDJQD76AKBDKEKBXELQZGTH3A5CNFSM4J4DS4L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHE22MQ#issuecomment-566865202>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMB7NCHUKMJAMMHOI4ED7DQZGTH3ANCNFSM4J4DS4LQ> .

[JohannMG]

[ FYI I'll be out Dec 21 and more or less offline until 2020 ]

[JohannMG]

Any blockers here?

[jp9000]

I'm sorry, I thought you were coming back to address the issues Fenrir had pointed out.

The only thing I see is that you use QTStr with some URLs. I think you might have misunderstood and thought it was used to create a QString, but it's actually used to look up string translations, not to create a string. You shouldn't need to even create a QString directly, just assigning a normal C-string should automatically convert it to a QString. So you can just do qstr = "https://bla.com"; and that should be perfectly fine.

[jp9000]

Additionally I agree that the fact that the edit box is small is not that big of a deal. We can always just increase the size of the dialog or something to compensate later.

[JohannMG]

Okay.
Todo for this PR:

• fix URLs using QStr
• Also fix usage of QStr in window-basic-settings-stream.cpp

Definitely on the radar but not in this diff:

• Fix various Wizard layout issues including like what Fenrir pointed out.

Will do possibly later

• Change stream key box size.

Sound good?

[jp9000]

Sounds good.

[JohannMG]

Okay.

• Updated to not use the QStr macro
• Rebased onto last master

I hope everyone had a chill new years break.

[JohannMG]

Updates were done: Good to merge?

[jp9000]

Yep. Thanks!