-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Source Toolbar #3268
Add Source Toolbar #3268
Conversation
I would like to see the extra widget per source available in struct obs_source_info so that I can set a custom widget in sources added via plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Ubuntu, due to the default UI font, the section for the source name feels very cramped. It doesn't fit the default "Screen Capture (XSHM)" source name.
The custom field for the text source on Ubuntu works correctly if there's only 1 line of text. More than one line causes the field to disappear completely. Not sure if this is intended.
With the "Window Capture (Xcomposite)" source on Ubuntu, an extra entry appears in the source toolbar that doesn't appear in the Properties window - "[Device not connected or not available]".
Overall, this seems to work great on both Ubuntu and Windows 10.
The multi-line thing is intended. It's not possible to edit a multi-line string on the context bar, and having a multi-line edit box in the context bar causes a lot of problems with layout and text selection anyway. The device not connected thing is intended as well. |
77ab591
to
226d597
Compare
In that case I would replace the text box with a button reading "Edit multi-line text" or "Edit paragraph". |
0caa5b7
to
b3448af
Compare
The source toolbar allows quick and easy access to properties and filers, and shows common properties/features of a source type. For example, when you select a media source, VLC source, or the slideshow source, you'll get media controls to control playback of the media. If you select a text source you can edit the font, color, or text if applicable. Or if you select a capture source, you can select the display/window/etc to capture for that source. If the source toolbar is not desired and is viewed as taking up valuable space in the window, it can be disabled via the view menu. Co-authored-by: Clayton Groeneveld <claytong1214@gmail.com> Co-authored-by: Jim <obs.jim@gmail.com>
Two custom styles (themeID=refreshIconSmall and themeID2=contextBarButton) to single widget introduces inconvenience to design OBS themes. I couldn't believe that making Browser Refresh button of two custom styles was the simplest solution. Please, avoid this is in the future. Give to the each element name and thus everything can be customized with |
Description
Adds a toolbar that allows quick and easy modification of most common/essential source properties or media controls without having to open a separate properties window:
Motivation and Context
Originally the reason why the context bar was created was to allow us a space to add media controls for the media source (play/pause/stop/seek). However, It didn't really have much use outside of media controls; it felt sort of like wasted space. So, I added quick access to essential properties/buttons specific for each main source type that OBS comes with. This turned out to be pretty useful and a little bit of a boost to user experience (in my humble opinion).
The source toolbar can be hidden via the view menu if the user would prefer not to have extra space used.
How Has This Been Tested?
Tested with all the various sources while making it. Primarily just tested on Windows though, will try to get some testing on macOS and Linux.
Types of changes
Checklist: