Unify color space settings as 709 #3415
Conversation
|
Is this safe to do? Wasn't there a guy in Discord who proposed doing this 6-8 months ago and was told no, and that sRGB should be the default? What's changed between then vs. now? Edit: it was a couple years ago, actually. @jp9000 stated that there were other problems caused by switching to 709 (affecting Twitch). |
|
We've done a fair amount of testing since, and Twitch seems to be decently fine with 709 on various devices. |
jpark37
force-pushed
the
default-color-space
branch
from
cbceb8d
to
f1abd1b
Compare
|
Revert back to 601 for now. I'd like to update the meaning of VIDEO_CS_DEFAULT, and also add plumbing for VIDEOINFOHEADER2, but these changes are going to take some time. |
jpark37
changed the title
I'll take this to mean "yes, the person who told us to do this 2 years ago was right". Thanks. |
|
Does that mean this issue has been fixed on both our side and Twitch app? |
|
The Android issue was device dependent. One device could have good 601 and bad 709, and another bad 601 and good 709: obsproject/rfcs#7 (comment) We did help the situation somewhat by submitting a fix, so that both the video stream and container are tagged: obsproject/rfcs#7 (comment) |
It seems like YouTube applies nonlinear-to-linear sRGB, and linear-to nonlinear-709 transformations to uploaded videos now. This makes sRGB too dark on their platform for video players that alias 709 as sRGB, which is almost everyone. Make 709 the default to keep peace.
jpark37
changed the title
jpark37
force-pushed
the
default-color-space
branch
from
f1abd1b
to
92d04c8
Compare
|
People don't want to go backwards to 601, so I've instead modified VIDEO_CS_DEFAULT to mean 709. Plumbing VIDEOINFOHEADER2 is a bit of a headache, but that can come later (if ever). Still needs more testing, which I can look at doing later today or tomorrow, so back to draft status. |
jpark37
force-pushed
the
default-color-space
branch
from
92d04c8
to
b1d8d9f
Compare
|
Fine with me as long as it's working on the majority of the expected outputs okay |
|
I should clarify: outputs and inputs. I would check to see where VIDEO_CS_DEFAULT is used and make sure any inputs that use it behave as expected. |
jpark37
force-pushed
the
default-color-space
branch
from
b1d8d9f
to
f4e0c9c
Compare
|
All changes have been tested. Do i need to do something extra for the documentation change? I'll mark this ready for review after the AMD encoder submodule PR is merged. |
jpark37
force-pushed
the
default-color-space
branch
2 times, most recently
from
bc28649
to
0d94f2b
Compare
Consistent with modified default UI setting.
jpark37
force-pushed
the
default-color-space
branch
from
0d94f2b
to
b6aface
Compare
|
Went back through, and tied up a few loose ends. I think I'm done. |
|
Documentation verified. Just waiting for submodule PR merge. |
Description
Change the default color setting in the UI from sRGB to 709, and VIDEO_CS_DEFAULT from 601 to 709.
Submodule PR: obsproject/obs-amd-encoder#405
Motivation and Context
It seems like YouTube applies nonlinear-to-linear sRGB, and
linear-to nonlinear-709 transformations to uploaded videos now. This
makes sRGB too dark on their platform for video players that alias 709
as sRGB, which is almost everyone. Make 709 the default to keep peace.
Update VIDEO_CS_DEFAULT to 709 for consistency.
How Has This Been Tested?
Debugger inspection of all changes.
Types of changes
Checklist: