-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Modernize about dialog #7298
base: master
Are you sure you want to change the base?
Conversation
At it's core the bottom navigation panel effectively imitated the functionality of a TabBar. Replacing it with an actual QTabWidget allows for re-use of pre-existing theming, and it's functionality is probably more recognizable. The previous navigation panel also had a few miscellaneous issues like: - no indication of button area - current selection didn't get highlighted - one could right click the label text to open a context menu Other small changes: - Seperate the about dialog into a small header and the main QTabWidget. - Rename the previous "About" section into the more appropriate "Patrons" - Introduce the "About" tab and consolidate generic project info and links into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe displaying Patrons by default is intentional, and should be kept.
I've personally been experimenting with ideas myself, and think the following would be worth discussing.
- Update the dialog to use the new logo - likely a copy of https://github.com/obsproject/obs-studio/blob/master/UI/xdg-data/icons/obs-logo-128.png
- Add an icon before the version number for the platform (Windows/macOS/Linux)
- The OBS logo should be vertically centered to match the text next to it
Thank you for submitting this PR, I'm excited to see this evolve.
In regards to your different points:
|
I like the modern design. If the patreons should be shown right away, how about just having it as a separate frame on the right? so the only tabs will be About, Authors, and License? You could maybe even have autoscroll, if that's possible? Just throwing suggestions. |
Thanks for the idea! Unfortunately I couldn't quite make it look right, I'm still learning lots about Qt but it's not quite enough to create good looking animations. But I ended up trying something similar by putting the "About" information next to the obs logo again. This is what it currently looks like: To summarize the main changes:
In regards to adding platform icons, I noticed that the website already has platform icons which would fit in very well: Any thoughts? |
Please hold off on further changes until @Warchamp7 can provide feedback. |
Two suggested changes:
|
Description
The basic layout of the about dialog got changed. A Tab bar replaces the previous bottom navigation panel as the main tool to navigate the about panel.
The OBS logo got moved into a smaller header above the tab bar containing only the logo itself, project name and version number. In turn general project information and links got consolidated into their own "About" tab and the previous "About" section got moved into the "Patrons" tab.
After:
Before:
Motivation and Context
The custom widget at the bottom of the about panel already imitated the functionality of a tab bar, replacing it with a QTabWidget makes the function more recognizable and adjusts well to pre-existing theming.
While the logo is important it simply took up too much space, the intention for shrinking and moving it was to shift the main focus on to the actual tab content.
I do recognize that changing that the UI is more of an art than science. I'd appreciate other thoughts on if this is even any better than the previous dialog, or how it could be improved by e.g: changes to layout, dimension, tab order, tab content...
How Has This Been Tested?
Tested on Windows 11 22H1
Types of changes
Checklist: