New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new events broadcast_starting, broadcast_started, broadcase_start_failed #7544
base: master
Are you sure you want to change the base?
Conversation
…rt_failed Added new events triggered by Go Live functionality in OBS for starting broadcasts on YouTube. These events can be very useful for script to know when the stream has actually gone live (as opposed to when streaming was started, which may have happened many minutes before). These events are particularly useful for calculating timestamps on YouTube.
Description should be added to the |
cleaning up comments based on pull request suggestions
Added documentation to docs/sphinx/reference-frontend-api.rst as suggested. |
There should probably be a stopping and stopped event as well, as the streaming and recording events have these, so we are consistent. |
moved failed event to BEFORE messagebox to user about it failing so it doesn't block waiting for user confirmation. in response to pull request comment by https://github.com/notr1ch
"There should probably be a stopping and stopped event as well, as the streaming and recording events have these, so we are consistent." <-- This would make intuitive sense, but it felt to me that there wasn't any real difference between stopping a broadcast and stopping streaming. Unlike the starting case, where broadcast can start much later than streaming, in the broadcasting case, when you stop broadcasting you stop streaming (as far as i can tell). However I would be happy to add the BroadcastStopping and BroadcastStopped events if that was the only thing holding up this code. |
I agree that if events specific to a broadcast lifecycle are added that we should add all of them (and not just the ones related to starting a broadcast). |
Added new events triggered by Go Live functionality in OBS for starting broadcasts on YouTube.
Description
Just a couple of new events to match the new GoLive button in OBS that transitions stream between streaming and actually going live.
Motivation and Context
These events can be very useful for script to know when the stream has actually gone live (as opposed to when streaming was started, which may have happened many minutes before). These events are particularly useful for calculating timestamps on YouTube.
How Has This Been Tested?
Tested on windows OBS version 27 and 28.
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: