PipeWire buffer transform #7762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
columbarius
force-pushed
the
pw-buffer-transform
branch
from
dbf67d8
to
1862912
Compare
|
I understand that this is a draft, but please make sure that you fully fill out the template. If the template isn't ready to be filled out, than the PR isn't ready for submission, even as a draft. |
columbarius
force-pushed
the
pw-buffer-transform
branch
2 times, most recently
from
3a417d2
to
74159e9
Compare
columbarius
force-pushed
the
pw-buffer-transform
branch
2 times, most recently
from
165179d
to
8a0d433
Compare
|
I guess I should again squash the guard commit? |
|
May this receive the 'Seeking testers' label, please? This should allow wlroots users to stream their screen correctly when the screen is rotated. |
columbarius
force-pushed
the
pw-buffer-transform
branch
7 times, most recently
from
d5e904b
to
d1b1f2e
Compare
|
Can confirm the flatpak build works with xdpw master and sway. |
columbarius
force-pushed
the
pw-buffer-transform
branch
3 times, most recently
from
9f87b36
to
f96c926
Compare
kkartaltepe
approved these changes
Dec 28, 2022
columbarius
force-pushed
the
pw-buffer-transform
branch
from
f96c926
to
b327834
Compare
|
Build a flatpak version of this MR without bumping the PipeWire version and it works as expected without doing any rotation. |
columbarius
force-pushed
the
pw-buffer-transform
branch
from
b327834
to
df219c3
Compare
|
rebased and conflicts resolved. |
PipeWire allows since 0.3.62 [1] to attach metadata to a buffer describing a transformation of the buffercontent. Clients should then undo that transformation to import it correctly. We can enable this feature using macro guards and runtime server version checks on supported systems. [1] https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/1423
GeorgesStavracas
force-pushed
the
pw-buffer-transform
branch
from
df219c3
to
8358f03
Compare
GeorgesStavracas
approved these changes
Feb 24, 2023
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Import PipeWire buffers respecting previously applied transformations.
Motivation and Context
The wlroots Portal implementation won't transform buffers and as such a screencast is displayed wrongly if the output is rotated. This MR aims to prototype PipeWire buffer transformation informations to read the screencontent correctly from the rotated buffer.
How Has This Been Tested?
No test available yet.
Types of changes
Checklist: