Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Restrict GNOME wayland override #7943

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

kkartaltepe
Copy link
Collaborator

Description

Some wayland compositors exclusively use xwayland such as gamescope. This allows us to fallback to the platform determined by Qt, which will detect these exotic compositors and handle them correctly when not overidden by this envvar.

Qt preserves this undesired behavior until 6.3. With ubuntu 22 on 6.2 this workaround needs to be preserved.

fixes #6386

Motivation and Context

OBS starts on weird platforms without manual override.

How Has This Been Tested?

OBS runs when gamescope doesnt crash.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Some wayland compositors exclusively use xwayland such as gamescope.
This allows us to fallback to the platform determined by Qt, which will
detect these exotic compositors and handle them correctly when not
overidden by this envvar.

Qt preserves this undesired behavior until 6.3. With ubuntu 22 on 6.2
this workaround needs to be preserved.

fixes obsproject#6386
@RytoEX RytoEX added the Bug Fix Non-breaking change which fixes an issue label Dec 20, 2022
@GeorgesStavracas GeorgesStavracas merged commit 1b8a695 into obsproject:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not running on steam deck (game mode)
3 participants