Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libobs: Fix stopping transitions that are not active #8003

Merged
merged 1 commit into from Jan 14, 2023

Conversation

exeldro
Copy link
Contributor

@exeldro exeldro commented Jan 3, 2023

Description

Fix stopping transitions that are not active

Motivation and Context

For transitions in the properties dialog (cloned private source) no audio render is done, so the transition never stopped, it kept waiting for the audio to finish. With these changes it will set the audio as done when video is done.

How Has This Been Tested?

On windows 64 bit by checking if transition_stop function is called after the preview button is clicked in the properties dialog of a transition.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Bug Fix Non-breaking change which fixes an issue label Jan 7, 2023
@jp9000 jp9000 merged commit eb35b07 into obsproject:master Jan 14, 2023
@RytoEX RytoEX mentioned this pull request Jan 19, 2023
6 tasks
@RytoEX RytoEX added this to the OBS Studio 29.0 milestone Jan 25, 2023
@exeldro exeldro deleted the stop_not_active_transition branch June 15, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants