UI: Add space for right arrow in menu

[exeldro]

Description

Add space for right arrow in menu

Motivation and Context

When making custom menu I noticed that the right arrow was on top of the text.
It looks to me that it is caused by setting the padding for QMenu::item to 6px in the theme.
Now I override only the right padding for QMenu::item to 12px
Before:

After:

The dark and system theme don't set the padding and don't have the issue.

How Has This Been Tested?

On windows 64 by having only 1 menu item that has a right arrow.

Types of changes

• Tweak (non-breaking change to improve existing functionality)

Checklist:

• My code has been run through clang-format.
• I have read the contributing document.
• My code is not on the master branch.
• The code has been tested.
• All commit messages are properly formatted and commits squashed where appropriate.
• I have included updates to all appropriate documentation.

[GeorgesStavracas]

Does this behave properly with right-to-left locales?

[exeldro]

Does this behave properly with right-to-left locales?

No idea, what would be a good way to test that?
The arrow is called QMenu::right-arrow in qt so I expect it to always be on the right

[GeorgesStavracas]

I don't really know, sorry. On Linux, usually launching the application with an RTL locale (e.g. LC_ALL=he-IL.utf8 obs) would be enough, but I'm not sure if Qt will respect that.

[RytoEX]

Does this behave properly with right-to-left locales?

I came here to ask the same question. Ideally, I'd like to know how this behaves in an RTL language/locale context.

[exeldro]

Tested right-to-left by adding program.setLayoutDirection(Qt::RightToLeft); to obs-app.cpp
Al seems to work correct:

[WizardCM]

It's worth noting this also occurs on the system tray context menu on Windows. Reportedly this is because none of the QMenu items have an icon/checkbox.

I've tested this PR on Windows and verified it improves the behaviour. I will be testing on macOS and Linux momentarily.

[WizardCM]

I have verified this does not introduce any negative side effects on Linux or macOS.

However, I vote for changing it to 20px.

[exeldro]

Made it 20px

[GeorgesStavracas]

LGTM from the screenshots

[RytoEX]

Seems better than the current situation.

Looks good to me.