New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add volume controls to properties window #8395
Conversation
Love this idea. Couple of unhandled edge cases: If a source can support audio, but doesn't currently, the volume meter is still shown. This includes:
|
7cfbe87
to
f8ce003
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get a frame or widget containing the volume widget in the With Preview version, so we can have some spacing between the video preview and the volume bar. It's a bit cramped right now.
How does this behave with private sources like Transitions?
f8ce003
to
62271b3
Compare
This makes it easier for users to edit volume controls of a source, without first closing the properties window.
62271b3
to
f1f420a
Compare
@Warchamp7 updated to have spacing between preview and volume controls. It doesn't work with transitions at this time, so it is hidden for them. |
Would also not mind the ability to change the Monitor/output status in the properties here, without having to go in to the Advanced Audio Properties dialog. Personally I would like to see the db/% value input field instead of (or in addition to) the volume monitor, that way I can set it to positive db values (in case a gain filter only isn't enough to boost audio levels on quiet sources). Would the orientation of the volume slider in this dialog match the setting in the Audio Mixer dock (horizontal/vertical)? |
This will be part of a bigger properties redesign, so I will close until that is finished. |
Description
This makes it easier for users to edit volume controls of a source, without first closing the properties window.
With preview:
Without preview:
Motivation and Context
Seems like a good idea. It's a small change, so if others don't like it, that's fine to me.
How Has This Been Tested?
Open properties of sources with audio.
Types of changes
Checklist: