Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add volume controls to properties window #8395

Closed
wants to merge 1 commit into from

Conversation

cg2121
Copy link
Contributor

@cg2121 cg2121 commented Mar 3, 2023

Description

This makes it easier for users to edit volume controls of a source, without first closing the properties window.

With preview:
Screenshot from 2023-03-06 07-32-51

Without preview:
Screenshot from 2023-03-02 21-06-58

Motivation and Context

Seems like a good idea. It's a small change, so if others don't like it, that's fine to me.

How Has This Been Tested?

Open properties of sources with audio.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX added New Feature New feature or plugin UI/UX Anything to do with changes or additions to UI/UX elements. labels Mar 3, 2023
@cg2121 cg2121 requested a review from Warchamp7 March 3, 2023 03:24
@WizardCM
Copy link
Member

WizardCM commented Mar 3, 2023

Love this idea. Couple of unhandled edge cases:

If a source can support audio, but doesn't currently, the volume meter is still shown. This includes:

  1. Browser source with "Control audio via OBS" off
  2. Video Capture Device source on Windows with "Audio Output Mode" set to either DirectSound or WaveOut

Copy link
Member

@Warchamp7 Warchamp7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a frame or widget containing the volume widget in the With Preview version, so we can have some spacing between the video preview and the volume bar. It's a bit cramped right now.

How does this behave with private sources like Transitions?

This makes it easier for users to edit volume controls of a source,
without first closing the properties window.
@cg2121
Copy link
Contributor Author

cg2121 commented Mar 6, 2023

@Warchamp7 updated to have spacing between preview and volume controls. It doesn't work with transitions at this time, so it is hidden for them.

Screenshot from 2023-03-06 07-32-51

@cg2121 cg2121 requested a review from Warchamp7 March 6, 2023 13:35
@Wiethoofd
Copy link

Would also not mind the ability to change the Monitor/output status in the properties here, without having to go in to the Advanced Audio Properties dialog.

Personally I would like to see the db/% value input field instead of (or in addition to) the volume monitor, that way I can set it to positive db values (in case a gain filter only isn't enough to boost audio levels on quiet sources).

Would the orientation of the volume slider in this dialog match the setting in the Audio Mixer dock (horizontal/vertical)?

@cg2121 cg2121 added this to the OBS Studio 29.1 milestone Mar 24, 2023
@cg2121
Copy link
Contributor Author

cg2121 commented Jul 29, 2023

This will be part of a bigger properties redesign, so I will close until that is finished.

@cg2121 cg2121 closed this Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature or plugin UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants