Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Move saving of scene tree grid mode #8908

Merged
merged 2 commits into from
May 21, 2023
Merged

UI: Move saving of scene tree grid mode #8908

merged 2 commits into from
May 21, 2023

Conversation

cg2121
Copy link
Contributor

@cg2121 cg2121 commented May 14, 2023

Description

This now saves the grid mode in the grid mode toggle action in the OBSBasic class.

Motivation and Context

Widgets should not save their own states, just in case they are used elsewhere.

How Has This Been Tested?

Toggled grid mode

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@cg2121 cg2121 added the Code Cleanup Non-breaking change which makes code smaller or more readable label May 15, 2023
@cg2121 cg2121 force-pushed the grid-mode-save branch 5 times, most recently from 4bbd7fe to 011c342 Compare May 21, 2023 01:44
@cg2121
UI: Fix compiling error on Ubuntu
3b3dc0f 
Makes sure ceil function uses std namespace
@cg2121
UI: Move saving of scene tree grid mode
0c64673 
Widget shouldn't save their own states, as then they can't be used
elsewhere.
@Lain-B Lain-B merged commit fc8c428 into obsproject:master May 21, 2023
12 checks passed
@cg2121 cg2121 deleted the grid-mode-save branch July 1, 2023 11:43
@RytoEX RytoEX added this to the OBS Studio (Next Release) milestone Aug 10, 2023
@RytoEX RytoEX mentioned this pull request May 19, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Cleanup Non-breaking change which makes code smaller or more readable
Projects
None yet
Milestone
OBS Studio 30.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cg2121 @RytoEX @Lain-B